Skip to content

Add dcx shortcut for docker compose exec with HTTP proxy env vars #4067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Nov 28, 2025
Merged

Add dcx shortcut for docker compose exec with HTTP proxy env vars #4067

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d38f2a2
Initial plan
Copilot Nov 27, 2025
850c283
Add dcep shortcut for docker compose exec with http proxy
Copilot Nov 27, 2025
8d74702
Quote environment variable values in dcep shortcut
Copilot Nov 27, 2025
5375e5b
Rename dcep to dcx (docker compose exec shortcut)
Copilot Nov 27, 2025
1c9aa8c
Move dcx after if/else block and use exec_proxy_args for DRY
Copilot Nov 28, 2025
343c441
Remove exec_proxy_args and inline proxy flags in dcx
Copilot Nov 28, 2025
49ca442
Add exec_proxy_args variable and use it in dcx definition
Copilot Nov 28, 2025
72e3d4e
Merge branch 'master' into copilot/create-bash-shortcut-docker
aldy505 Nov 28, 2025
dc1a28f
Use $dcx shortcut in bootstrap-s3-profiles.sh
Copilot Nov 28, 2025
148dbd9
Merge branch 'master' into copilot/create-bash-shortcut-docker
aldy505 Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion install/bootstrap-s3-nodestore.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
echo "${_group}Bootstrapping seaweedfs (node store)..."

$dc up --wait seaweedfs postgres
$dc exec -e "HTTP_PROXY=${HTTP_PROXY:-}" -e "HTTPS_PROXY=${HTTPS_PROXY:-}" -e "NO_PROXY=${NO_PROXY:-}" -e "http_proxy=${http_proxy:-}" -e "https_proxy=${https_proxy:-}" -e "no_proxy=${no_proxy:-}" seaweedfs apk add --no-cache s3cmd
$dcep seaweedfs apk add --no-cache s3cmd
$dc exec seaweedfs mkdir -p /data/idx/
s3cmd="$dc exec seaweedfs s3cmd"

Expand Down
2 changes: 2 additions & 0 deletions install/dc-detect-version.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ else
fi

proxy_args="--build-arg HTTP_PROXY=${HTTP_PROXY:-} --build-arg HTTPS_PROXY=${HTTPS_PROXY:-} --build-arg NO_PROXY=${NO_PROXY:-} --build-arg http_proxy=${http_proxy:-} --build-arg https_proxy=${https_proxy:-} --build-arg no_proxy=${no_proxy:-}"
# Shortcut for docker compose exec with http proxy environment variables
dcep="$dc exec -e \"HTTP_PROXY=${HTTP_PROXY:-}\" -e \"HTTPS_PROXY=${HTTPS_PROXY:-}\" -e \"NO_PROXY=${NO_PROXY:-}\" -e \"http_proxy=${http_proxy:-}\" -e \"https_proxy=${https_proxy:-}\" -e \"no_proxy=${no_proxy:-}\""
Copy link
Member

@BYK BYK Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
dcep="$dc exec -e \"HTTP_PROXY=${HTTP_PROXY:-}\" -e \"HTTPS_PROXY=${HTTPS_PROXY:-}\" -e \"NO_PROXY=${NO_PROXY:-}\" -e \"http_proxy=${http_proxy:-}\" -e \"https_proxy=${https_proxy:-}\" -e \"no_proxy=${no_proxy:-}\""
dcx="$dc exec -e \"HTTP_PROXY=${HTTP_PROXY:-}\" -e \"HTTPS_PROXY=${HTTPS_PROXY:-}\" -e \"NO_PROXY=${NO_PROXY:-}\" -e \"http_proxy=${http_proxy:-}\" -e \"https_proxy=${https_proxy:-}\" -e \"no_proxy=${no_proxy:-}\""

Let's rename this to dcx (short for docker compose exec) and find all relevant occurances in the codebase and replace them with dcx (not just in install/bootstrap-s3-nodestore.sh)

Copy link
Contributor Author

Copilot AI Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed to dcx in commit 5375e5b. I've searched the codebase and the only occurrence of the proxy pattern in exec was in bootstrap-s3-nodestore.sh, which is now updated to use $dcx.

if [[ "$CONTAINER_ENGINE" == "podman" ]]; then
proxy_args_dc="--podman-build-args HTTP_PROXY=${HTTP_PROXY:-},HTTPS_PROXY=${HTTPS_PROXY:-},NO_PROXY=${NO_PROXY:-},http_proxy=${http_proxy:-},https_proxy=${https_proxy:-},no_proxy=${no_proxy:-}"
# Disable pod creation as these are one-off commands and creating a pod
Expand Down