Skip to content

Commit 2f93346

Browse files
authored
chore(build): Remove experimental designation from build subcommand in prep for beta release (#2899)
### Description Removes `[EXPERIMENTAL]` designation from `build` subcommand in prep for upcoming Nov 6 EA/Beta launch of size analysis and other preprod features. ### Issues - Resolves EME-71 <!-- #### Reminders - Add GH Issue ID _&_ Linear ID (if applicable) - PR title should use [conventional commit](https://develop.sentry.dev/engineering-practices/commit-messages/#type) style (`feat:`, `fix:`, `ref:`, `meta:`) - For external contributors: [CONTRIBUTING.md](https://github.com/getsentry/sentry-cli/blob/master/CONTRIBUTING.md), [Sentry SDK development docs](https://develop.sentry.dev/sdk/), [Discord community](https://discord.gg/Ww9hbqr) -->
1 parent 8c6e63e commit 2f93346

File tree

9 files changed

+6
-16
lines changed

9 files changed

+6
-16
lines changed

src/commands/build/mod.rs

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ pub fn make_command(mut command: Command) -> Command {
2121
}
2222

2323
command = command
24-
.about("[EXPERIMENTAL] Manage builds.")
24+
.about("Manage builds.")
2525
.subcommand_required(true)
2626
.arg_required_else_help(true)
2727
.org_arg()
@@ -33,12 +33,6 @@ pub fn make_command(mut command: Command) -> Command {
3333
}
3434

3535
pub fn execute(matches: &ArgMatches) -> Result<()> {
36-
log::warn!(
37-
"EXPERIMENTAL: The build subcommand is experimental. \
38-
The command is subject to breaking changes and may be removed \
39-
without notice in any release."
40-
);
41-
4236
macro_rules! execute_subcommand {
4337
($name:ident) => {{
4438
if let Some(sub_matches) =

src/commands/build/upload.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ pub fn make_command(command: Command) -> Command {
3737
const HELP_TEXT: &str =
3838
"The path to the build to upload. Supported files include Apk, and Aab.";
3939
command
40-
.about("[EXPERIMENTAL] Upload builds to a project.")
40+
.about("Upload builds to a project.")
4141
.org_arg()
4242
.project_arg(false)
4343
.arg(

tests/integration/_cases/build/build-help.trycmd

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
```
22
$ sentry-cli build --help
33
? success
4-
[EXPERIMENTAL] Manage builds.
4+
Manage builds.
55

66
Usage: sentry-cli[EXE] build [OPTIONS] <COMMAND>
77

88
Commands:
9-
upload [EXPERIMENTAL] Upload builds to a project.
9+
upload Upload builds to a project.
1010
help Print this message or the help of the given subcommand(s)
1111

1212
Options:

tests/integration/_cases/build/build-upload-apk-all-uploaded.trycmd

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
```
22
$ sentry-cli build upload tests/integration/_fixtures/build/apk.apk
33
? success
4-
WARN [..] EXPERIMENTAL: The build subcommand is experimental. The command is subject to breaking changes and may be removed without notice in any release.
54
> Preparing for upload completed in [..]
65
Successfully uploaded 1 file to Sentry
76
- tests/integration/_fixtures/build/apk.apk (http[..]/wat-org/preprod/wat-project/42)

tests/integration/_cases/build/build-upload-apk-no-token.trycmd

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
```
22
$ sentry-cli build upload tests/integration/_fixtures/build/apk.apk
33
? failed
4-
WARN [..] EXPERIMENTAL: The build subcommand is experimental. The command is subject to breaking changes and may be removed without notice in any release.
54
error: Auth token is required for this request. Please run `sentry-cli login` and try again!
65

76
Add --log-level=[info|debug] or export SENTRY_LOG_LEVEL=[info|debug] to see more output.

tests/integration/_cases/build/build-upload-apk.trycmd

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
```
22
$ sentry-cli build upload tests/integration/_fixtures/build/apk.apk --head-sha test_head_sha
33
? success
4-
WARN [..] EXPERIMENTAL: The build subcommand is experimental. The command is subject to breaking changes and may be removed without notice in any release.
54
> Preparing for upload completed in [..]
65
> Uploading completed in [..]
76
Successfully uploaded 1 file to Sentry

tests/integration/_cases/build/build-upload-help-macos.trycmd

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
```
22
$ sentry-cli build upload --help
33
? success
4-
[EXPERIMENTAL] Upload builds to a project.
4+
Upload builds to a project.
55

66
Usage: sentry-cli[EXE] build upload [OPTIONS] <PATH>...
77

tests/integration/_cases/build/build-upload-help-not-macos.trycmd

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
```
22
$ sentry-cli build upload --help
3-
[EXPERIMENTAL] Upload builds to a project.
3+
Upload builds to a project.
44

55
Usage: sentry-cli[EXE] build upload [OPTIONS] <PATH>...
66

tests/integration/_cases/build/build-upload-ipa.trycmd

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
```
22
$ sentry-cli build upload tests/integration/_fixtures/build/ipa.ipa --head-sha test_head_sha
33
? success
4-
WARN [..] EXPERIMENTAL: The build subcommand is experimental. The command is subject to breaking changes and may be removed without notice in any release.
54
> Preparing for upload completed in [..]
65
Successfully uploaded 1 file to Sentry
76
- tests/integration/_fixtures/build/ipa.ipa (http[..]/wat-org/preprod/wat-project/some-text-id)

0 commit comments

Comments
 (0)