feat: Support missing calls with multi-project the options

Author: JPeer264

CHANGELOG.md

@@ -53,6 +53,8 @@ The following changes only apply when using `sentry-cli` via the npm package [`@
 ### Improvements
 
 - The `sentry-cli upload-proguard` command now uses chunked uploading by default ([#2918](https://github.com/getsentry/sentry-cli/pull/2918)). Users who previously set the `SENTRY_EXPERIMENTAL_PROGUARD_CHUNK_UPLOAD` environment variable to opt into this behavior no longer need to set the variable.
+- In the JavaScript API, added multi-project support to `releases.finalize()`, `releases.setCommits()`, and `releases.newDeploy()` methods. These methods now accept a `projects` option (array of project slugs), aligning them with the Rust CLI's multi-project capabilities and matching the existing behavior of `releases.new()` and `releases.uploadSourceMaps()`.
+
 
 ### Fixes
 

lib/releases/__tests__/index.test.js

@@ -144,5 +144,100 @@ describe('SentryCli releases', () => {
         );
       });
     });
+
+    describe('finalize', () => {
+      test('without projects', async () => {
+        await cli.releases.finalize('my-version');
+
+        expect(mockExecute).toHaveBeenCalledWith(
+          ['releases', 'finalize', 'my-version'],
+          null,
+          false,
+          undefined,
+          { silent: false }
+        );
+      });
+
+      test('with projects', async () => {
+        await cli.releases.finalize('my-version', { projects: ['proj-a', 'proj-b'] });
+
+        expect(mockExecute).toHaveBeenCalledWith(
+          ['releases', 'finalize', '-p', 'proj-a', '-p', 'proj-b', 'my-version'],
+          null,
+          false,
+          undefined,
+          { silent: false }
+        );
+      });
+    });
+
+    describe('setCommits', () => {
+      test('without projects', async () => {
+        await cli.releases.setCommits('my-version', { auto: true });
+
+        expect(mockExecute).toHaveBeenCalledWith(
+          ['releases', 'set-commits', 'my-version', '--auto'],
+          false,
+          false,
+          undefined,
+          { silent: false }
+        );
+      });
+
+      test('with projects', async () => {
+        await cli.releases.setCommits('my-version', {
+          auto: true,
+          projects: ['proj-a', 'proj-b'],
+        });
+
+        expect(mockExecute).toHaveBeenCalledWith(
+          ['releases', 'set-commits', '-p', 'proj-a', '-p', 'proj-b', 'my-version', '--auto'],
+          false,
+          false,
+          undefined,
+          { silent: false }
+        );
+      });
+    });
+
+    describe('newDeploy', () => {
+      test('without projects', async () => {
+        await cli.releases.newDeploy('my-version', { env: 'production' });
+
+        expect(mockExecute).toHaveBeenCalledWith(
+          ['releases', 'deploys', 'my-version', 'new', '--env', 'production'],
+          null,
+          false,
+          undefined,
+          { silent: false }
+        );
+      });
+
+      test('with projects', async () => {
+        await cli.releases.newDeploy('my-version', {
+          env: 'production',
+          projects: ['proj-a', 'proj-b'],
+        });
+
+        expect(mockExecute).toHaveBeenCalledWith(
+          [
+            'releases',
+            'deploys',
+            '-p',
+            'proj-a',
+            '-p',
+            'proj-b',
+            'my-version',
+            'new',
+            '--env',
+            'production',
+          ],
+          null,
+          false,
+          undefined,
+          { silent: false }
+        );
+      });
+    });
   });
 });

lib/releases/index.ts

@@ -2,6 +2,7 @@
 
 import {
   SentryCliCommitsOptions,
+  SentryCliFinalizeReleaseOptions,
   SentryCliNewDeployOptions,
   SentryCliOptions,
   SentryCliUploadSourceMapsOptions,
@@ -62,18 +63,28 @@ export class Releases {
       commitFlags.push('--ignore-missing');
     }
 
-    return this.execute(['releases', 'set-commits', release].concat(commitFlags), false);
+    return this.execute(
+      ['releases', 'set-commits']
+        .concat(helper.getProjectFlagsFromOptions(options))
+        .concat([release])
+        .concat(commitFlags),
+      false
+    );
   }
 
   /**
    * Marks this release as complete. This should be called once all artifacts has been
    * uploaded.
    *
    * @param release Unique name of the release.
+   * @param options Options to configure which projects to finalize the release for.
    * @returns A promise that resolves when the release has been finalized.
    */
-  async finalize(release: string): Promise<string> {
-    return this.execute(['releases', 'finalize', release], null);
+  async finalize(release: string, options?: SentryCliFinalizeReleaseOptions): Promise<string> {
+    const args = ['releases', 'finalize']
+      .concat(helper.getProjectFlagsFromOptions(options))
+      .concat([release]);
+    return this.execute(args, null);
   }
 
   /**
@@ -203,6 +214,7 @@ export class Releases {
    *   time: 1295,                 // deployment duration in seconds. This can be specified alternatively to `started` and `finished`
    *   name: 'PickleRick',         // human readable name for this deployment
    *   url: 'https://example.com', // URL that points to the deployment
+   *   projects: ['project1', 'project2'], // list of projects to deploy to
    * });
    *
    * @param release Unique name of the release.
@@ -213,7 +225,9 @@ export class Releases {
     if (!options || !options.env) {
       throw new Error('options.env must be a valid name');
     }
-    const args = ['releases', 'deploys', release, 'new'];
+    const args = ['releases', 'deploys']
+      .concat(helper.getProjectFlagsFromOptions(options))
+      .concat([release, 'new']);
     return this.execute(helper.prepareCommand(args, DEPLOYS_OPTIONS, options), null);
   }
 

lib/types.ts

@@ -147,6 +147,16 @@ export type SentryCliUploadSourceMapsOptions = {
   useArtifactBundle?: boolean;
 }
 
+/**
+ * Options for finalizing a release
+ */
+export interface SentryCliFinalizeReleaseOptions {
+  /**
+   * The projects to finalize the release for. If not provided, the release will be finalized for the default project.
+   */
+  projects?: string[];
+}
+
 /**
  * Options for creating a new deployment
  */
@@ -175,6 +185,10 @@ export type SentryCliNewDeployOptions = {
    * URL that points to the deployment.
    */
   url?: string;
+  /**
+   * The projects to deploy the release to. If not provided, the deployment will be created for the default project.
+   */
+  projects?: string[];
 }
 
 /**
@@ -208,4 +222,8 @@ export type SentryCliCommitsOptions = {
    * When the flag is set, command will not fail and just exit silently if no new commits for a given release have been found.
    */
   ignoreEmpty?: boolean;
+  /**
+   * The projects to set commits for. If not provided, commits will be set for the default project.
+   */
+  projects?: string[];
 }