Skip to content

Commit 80a9edc

Browse files
ci: Enable Danger (#2838)
### Description Add the [Danger check](https://github.com/getsentry/github-workflows/tree/main/danger), which ensures that the changelog is updated with each user-facing PR, among other things. This will be helpful to have, especially as we begin work on the 3.0 major, as we can focus on writing a user-facing, human-readable changelog with every change we make, rather than needing to write the changelog at the end. ### Issues - Resolves #2595 - Resolves CLI-133 <!-- #### Reminders - Add GH Issue ID _&_ Linear ID (if applicable) - PR title should use [conventional commit](https://develop.sentry.dev/engineering-practices/commit-messages/#type) style (`feat:`, `fix:`, `ref:`, `meta:`) - For external contributors: [CONTRIBUTING.md](https://github.com/getsentry/sentry-cli/blob/master/CONTRIBUTING.md), [Sentry SDK development docs](https://develop.sentry.dev/sdk/), [Discord community](https://discord.gg/Ww9hbqr) -->
1 parent 73eced7 commit 80a9edc

File tree

1 file changed

+20
-2
lines changed

1 file changed

+20
-2
lines changed

.github/workflows/ci.yml

Lines changed: 20 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,14 +37,32 @@ jobs:
3737
name: Test Swift
3838
uses: ./.github/workflows/swift-test.yml
3939

40+
danger:
41+
name: Run Danger Checks
42+
runs-on: ubuntu-24.04
43+
permissions:
44+
contents: read
45+
pull-requests: write
46+
statuses: write
47+
if: ${{ github.event_name == 'pull_request' }}
48+
steps:
49+
- name: Run Danger
50+
uses: getsentry/github-workflows/danger@13be9bec4ec5cd67061b747972b996e9c80f4f3b # 3.1.0
51+
4052
required:
4153
name: Check required jobs
4254
runs-on: ubuntu-24.04
43-
needs: [lint, test, test_node, test_swift]
55+
needs: [lint, test, test_node, test_swift, danger]
4456
if: always()
4557
steps:
4658
- name: Check for failure
47-
if: ${{ needs.lint.result != 'success' || needs.test.result != 'success' || needs.test_node.result != 'success' || needs.test_swift.result != 'success' }}
59+
if: ${{
60+
needs.lint.result != 'success' ||
61+
needs.test.result != 'success' ||
62+
needs.test_node.result != 'success' ||
63+
needs.test_swift.result != 'success' ||
64+
(needs.danger.result != 'success' && needs.danger.result != 'skipped')
65+
}}
4866
run: |
4967
echo "One or more jobs failed"
5068
exit 1

0 commit comments

Comments
 (0)