feat(proguard): Remove release association arguments

szokeasaurusrex · szokeasaurusrex · commit 9918aaa1ccc0 · 2025-11-10T10:39:34.000+01:00
Remove the `--app-id`, `--version`, and `--version-code` arguments to the `sentry-cli upload-proguard` command. Users currently using these arguments should simply stop using them. This change also removes any code that had been called when these flags were specified. Resolves #2868 Resolves [CLI-197](https://linear.app/getsentry/issue/CLI-197/remove-flags-for-setting-release)
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,10 @@
 
 ## Unreleased
 
+### Breaking changes
+
+- Removed the `upload-proguard` subcommand's `--app-id`, `--version`, and `--version-code` arguments ([#2876](https://github.com/getsentry/sentry-cli/pull/2876)). Users using these arguments should stop using them, as they are unnecessary. The information passed to these arguments is no longer visible in Sentry.
+
 ### Improvements
 
 - The `sentry-cli debug-files bundle-jvm` no longer makes any HTTP requests to Sentry, meaning auth tokenms are no longer needed, and the command can be run offline ([#2926](https://github.com/getsentry/sentry-cli/pull/2926)).
diff --git a/src/api/mod.rs b/src/api/mod.rs
@@ -1059,36 +1059,6 @@ impl<'a> AuthenticatedApi<'a> {
             .convert_rnf(ApiErrorKind::ProjectNotFound)
     }
 
-    pub fn associate_proguard_mappings(
-        &self,
-        org: &str,
-        project: &str,
-        data: &AssociateProguard,
-    ) -> ApiResult<()> {
-        let path = format!(
-            "/projects/{}/{}/files/proguard-artifact-releases",
-            PathArg(org),
-            PathArg(project)
-        );
-        let resp: ApiResponse = self
-            .request(Method::Post, &path)?
-            .with_json_body(data)?
-            .send()?;
-        if resp.status() == 201 {
-            Ok(())
-        } else if resp.status() == 409 {
-            info!(
-                "Release association for release '{}', UUID '{}' already exists.",
-                data.release_name, data.proguard_uuid
-            );
-            Ok(())
-        } else if resp.status() == 404 {
-            Err(ApiErrorKind::ResourceNotFound.into())
-        } else {
-            resp.convert()
-        }
-    }
-
     /// List all organizations associated with the authenticated token
     /// in the given `Region`. If no `Region` is provided, we assume
     /// we're issuing a request to a monolith deployment.
@@ -2244,12 +2214,6 @@ impl DebugInfoFile {
     }
 }
 
-#[derive(Debug, Serialize)]
-pub struct AssociateProguard {
-    pub release_name: String,
-    pub proguard_uuid: String,
-}
-
 #[derive(Deserialize)]
 struct MissingChecksumsResponse {
     missing: HashSet<Digest>,
diff --git a/src/commands/upload_proguard.rs b/src/commands/upload_proguard.rs
@@ -9,7 +9,6 @@ use symbolic::common::ByteView;
 use uuid::Uuid;
 
 use crate::api::Api;
-use crate::api::AssociateProguard;
 use crate::config::Config;
 use crate::utils::android::dump_proguard_uuids_as_properties;
 use crate::utils::args::ArgExt as _;
@@ -33,62 +32,11 @@ pub fn make_command(command: Command) -> Command {
                 .num_args(1..)
                 .action(ArgAction::Append),
         )
-        .arg(
-            Arg::new("version")
-                .hide(true)
-                .long("version")
-                .value_name("VERSION")
-                .requires("app_id")
-                .help(
-                    "[DEPRECATED] Optionally associate the mapping files \
-                     with a human readable version.{n}This helps you \
-                     understand which ProGuard files go with which version \
-                     of your app.\n\
-                     Sentry SaaS and self-hosted version 25.9.0 and later no \
-                     longer display this association, as it has no effect on \
-                     deobfuscation. This flag is scheduled for removal in \
-                     Sentry CLI 3.0.0.",
-                ),
-        )
-        .arg(
-            Arg::new("version_code")
-                .hide(true)
-                .long("version-code")
-                .value_name("VERSION_CODE")
-                .requires("app_id")
-                .requires("version")
-                .help(
-                    "[DEPRECATED] Optionally associate the mapping files with a version \
-                     code.{n}This helps you understand which ProGuard files \
-                     go with which version of your app.\n\
-                     Sentry SaaS and self-hosted version 25.9.0 and later no \
-                     longer display this association, as it has no effect on \
-                     deobfuscation. This flag is scheduled for removal in \
-                     Sentry CLI 3.0.0.",
-                ),
-        )
-        .arg(
-            Arg::new("app_id")
-                .hide(true)
-                .long("app-id")
-                .value_name("APP_ID")
-                .requires("version")
-                .help(
-                    "[DEPRECATED] Optionally associate the mapping files with an application \
-                     ID.{n}If you have multiple apps in one sentry project, you can \
-                     then easily tell them apart.\n\
-                     Sentry SaaS and self-hosted version 25.9.0 and later no \
-                     longer display this association, as it has no effect on \
-                     deobfuscation. This flag is scheduled for removal in \
-                     Sentry CLI 3.0.0.",
-                ),
-        )
         .arg(
             Arg::new("platform")
                 .hide(true)
                 .long("platform")
                 .value_name("PLATFORM")
-                .requires("app_id")
                 .help(
                     "[DEPRECATED] This flag is a no-op, scheduled \
                     for removal in Sentry CLI 3.0.0.",
@@ -109,7 +57,6 @@ pub fn make_command(command: Command) -> Command {
             Arg::new("android_manifest")
                 .long("android-manifest")
                 .value_name("PATH")
-                .conflicts_with("app_id")
                 .hide(true)
                 .help(
                     "[DEPRECATED] This flag is a no-op, scheduled \
@@ -304,40 +251,5 @@ pub fn execute(matches: &ArgMatches) -> Result<()> {
         }
     }
 
-    // if values are given associate
-    if let Some(app_id) = matches.get_one::<String>("app_id") {
-        log::warn!(
-            "[DEPRECATION NOTICE] The --app-id, --version, and --version-code flags are deprecated. \
-            and scheduled for removal in Sentry CLI 3.0.0. \
-            These values have no effect on deobfuscation, and are no longer displayed anywhere \
-            in the Sentry UI (neither in SaaS nor in self-hosted versions 25.9.0 and later)."
-        );
-
-        #[expect(clippy::unwrap_used, reason = "legacy code")]
-        let version = matches.get_one::<String>("version").unwrap().to_owned();
-        let build: Option<String> = matches.get_one::<String>("version_code").cloned();
-
-        let mut release_name = app_id.to_owned();
-        release_name.push('@');
-        release_name.push_str(&version);
-
-        if let Some(build_str) = build {
-            release_name.push('+');
-            release_name.push_str(&build_str);
-        }
-
-        for mapping in &mappings {
-            let uuid = forced_uuid.copied().unwrap_or(mapping.uuid());
-            authenticated_api.associate_proguard_mappings(
-                &org,
-                &project,
-                &AssociateProguard {
-                    release_name: release_name.to_owned(),
-                    proguard_uuid: uuid.to_string(),
-                },
-            )?;
-        }
-    }
-
     Ok(())
 }
diff --git a/tests/integration/_cases/upload_proguard/upload_proguard-help.trycmd b/tests/integration/_cases/upload_proguard/upload_proguard-help.trycmd
@@ -14,15 +14,15 @@ Options:
                                  in key:value format.
   -p, --project <PROJECT>        The project ID or slug.
       --auth-token <AUTH_TOKEN>  Use the given Sentry auth token.
+      --no-upload                Disable the actual upload.
+                                 This runs all steps for the processing but does not trigger the
+                                 upload.  This is useful if you just want to verify the mapping
+                                 files and write the proguard UUIDs into a properties file.
       --log-level <LOG_LEVEL>    Set the log output verbosity. [possible values: trace, debug, info,
                                  warn, error]
       --quiet                    Do not print any output while preserving correct exit code. This
                                  flag is currently implemented only for selected subcommands.
                                  [aliases: --silent]
-      --no-upload                Disable the actual upload.
-                                 This runs all steps for the processing but does not trigger the
-                                 upload.  This is useful if you just want to verify the mapping
-                                 files and write the proguard UUIDs into a properties file.
       --write-properties <PATH>  Write the UUIDs for the processed mapping files into the given
                                  properties file.
       --require-one              Requires at least one file to upload or the command will error.
