diff --git a/CHANGELOG.md b/CHANGELOG.md index 99a0b5b6ba..4d0c054619 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -18,7 +18,7 @@ we should rename this section to "Unreleased" --> - `SENTRY_API_KEY` environment variable - `api_key` configuration file field - `apiKey` option in the JavaScript API -- Removed the `upload-proguard` subcommand's `--app-id`, `--version`, `--version-code`, and `--android-manifest` arguments ([#2876](https://github.com/getsentry/sentry-cli/pull/2876), [#2940](https://github.com/getsentry/sentry-cli/pull/2940)). Users using these arguments should stop using them, as they are unnecessary. The information passed to these arguments is no longer visible in Sentry. +- Removed the `upload-proguard` subcommand's `--app-id`, `--version`, `--version-code`, `--android-manifest`, and `--platform` arguments ([#2876](https://github.com/getsentry/sentry-cli/pull/2876), [#2940](https://github.com/getsentry/sentry-cli/pull/2940), [#2948](https://github.com/getsentry/sentry-cli/pull/2948)). Users using these arguments should stop using them, as they are unnecessary. The information passed to these arguments is no longer visible in Sentry. ### Improvements diff --git a/src/commands/upload_proguard.rs b/src/commands/upload_proguard.rs index 36c72ca855..35658701ce 100644 --- a/src/commands/upload_proguard.rs +++ b/src/commands/upload_proguard.rs @@ -28,16 +28,6 @@ pub fn make_command(command: Command) -> Command { .num_args(1..) .action(ArgAction::Append), ) - .arg( - Arg::new("platform") - .hide(true) - .long("platform") - .value_name("PLATFORM") - .help( - "[DEPRECATED] This flag is a no-op, scheduled \ - for removal in Sentry CLI 3.0.0.", - ), - ) .arg( Arg::new("no_upload") .long("no-upload") @@ -82,14 +72,6 @@ pub fn make_command(command: Command) -> Command { } pub fn execute(matches: &ArgMatches) -> Result<()> { - if matches.get_one::("platform").is_some() { - log::warn!( - "[DEPRECATION NOTICE] The --platform argument is deprecated, \ - and is scheduled for removal in Sentry CLI 3.0.0. \ - The argument is a no-op." - ); - } - let paths: Vec<_> = match matches.get_many::("paths") { Some(paths) => paths.collect(), None => { diff --git a/tests/integration/_cases/upload_proguard/upload_proguard-help.trycmd b/tests/integration/_cases/upload_proguard/upload_proguard-help.trycmd index f764213a32..1a04f16588 100644 --- a/tests/integration/_cases/upload_proguard/upload_proguard-help.trycmd +++ b/tests/integration/_cases/upload_proguard/upload_proguard-help.trycmd @@ -14,17 +14,17 @@ Options: in key:value format. -p, --project The project ID or slug. --auth-token Use the given Sentry auth token. - --log-level Set the log output verbosity. [possible values: trace, debug, info, - warn, error] --no-upload Disable the actual upload. This runs all steps for the processing but does not trigger the upload. This is useful if you just want to verify the mapping files and write the proguard UUIDs into a properties file. + --log-level Set the log output verbosity. [possible values: trace, debug, info, + warn, error] + --write-properties Write the UUIDs for the processed mapping files into the given + properties file. --quiet Do not print any output while preserving correct exit code. This flag is currently implemented only for selected subcommands. [aliases: --silent] - --write-properties Write the UUIDs for the processed mapping files into the given - properties file. --require-one Requires at least one file to upload or the command will error. -u, --uuid Explicitly override the UUID of the mapping file with another one. This should be used with caution as it means that you can upload