fix: profiling memory growth fix (#3145)

- always ensure the profiler's timeout timer is scheduled on the main thread
- keep references to any aborted profiler until its associated transaction is finished
- fix testConcurrentSpansWithTimeout to properly regression test the scenario

Author: armcknight

CHANGELOG.md

@@ -11,6 +11,10 @@
 
 - Renamed `enableTimeToFullDisplay` to `enableTimeToFullDisplayTracing` (#3106)
     - This is an experimental feature and may change at any time without a major revision.
+    
+### Fixes
+
+- Fix potential unbounded memory growth when starting profiled transactions from non-main contexts (#3135)
 
 ## 8.9.0-beta.1
 

Sentry.xcodeproj/project.pbxproj

@@ -3112,7 +3112,6 @@
 				8454CF8B293EAF9A006AC140 /* SentryMetricProfiler.mm */,
 				03F84D1127DD414C008FE43F /* SentryProfiler.h */,
 				03F84D2B27DD4191008FE43F /* SentryProfiler.mm */,
-				84A888FC28D9B11700C51DFD /* SentryProfiler+Test.h */,
 				84A888FC28D9B11700C51DFD /* SentryProfiler+Private.h */,
 				0354A22A2A134D9C003C3A04 /* SentryProfilerState.h */,
 				84281C642A57D36100EE88F2 /* SentryProfilerState+ObjCpp.h */,

SentryTestUtils/ClearTestState.swift

@@ -42,6 +42,7 @@ class TestCleanup: NSObject {
         SentryTracer.resetAppStartMeasurementRead()
 
 #if os(iOS) || os(macOS) || targetEnvironment(macCatalyst)
+        SentryProfiler.getCurrent().stop(for: .normal)
         SentryTracer.resetConcurrencyTracking()
 #endif
     }

SentryTestUtils/SentryTestUtils-ObjC-BridgingHeader.h

@@ -21,6 +21,7 @@
 #import "SentryNSTimerFactory.h"
 #import "SentryNetworkTracker.h"
 #import "SentryPerformanceTracker+Testing.h"
+#import "SentryProfiler+Test.h"
 #import "SentryRandom.h"
 #import "SentrySDK+Private.h"
 #import "SentrySDK+Tests.h"

Sources/Sentry/SentryFramesTracker.m

@@ -123,7 +123,7 @@ - (void)displayLinkCallback
     }
 
 #    if SENTRY_TARGET_PROFILING_SUPPORTED
-    if ([SentryProfiler isRunning]) {
+    if ([SentryProfiler isCurrentlyProfiling]) {
         BOOL hasNoFrameRatesYet = self.frameRateTimestamps.count == 0;
         uint64_t previousFrameRate
             = self.frameRateTimestamps.lastObject[@"value"].unsignedLongLongValue;
@@ -179,7 +179,7 @@ - (void)reportNewFrame
 #    if SENTRY_TARGET_PROFILING_SUPPORTED
 - (void)recordTimestamp:(uint64_t)timestamp value:(NSNumber *)value array:(NSMutableArray *)array
 {
-    BOOL shouldRecord = [SentryProfiler isRunning];
+    BOOL shouldRecord = [SentryProfiler isCurrentlyProfiling];
 #        if defined(TEST) || defined(TESTCI)
     shouldRecord = YES;
 #        endif

Sources/Sentry/SentryNSNotificationCenterWrapper.m

@@ -46,7 +46,7 @@ + (NSNotificationName)willTerminateNotificationName
 - (void)addObserver:(id)observer
            selector:(SEL)aSelector
                name:(NSNotificationName)aName
-             object:(id)anObject
+             object:(nullable id)anObject
 {
     [NSNotificationCenter.defaultCenter addObserver:observer
                                            selector:aSelector
@@ -67,7 +67,7 @@ - (void)removeObserver:(id)observer name:(NSNotificationName)aName
     [NSNotificationCenter.defaultCenter removeObserver:observer name:aName object:nil];
 }
 
-- (void)removeObserver:(id)observer name:(NSNotificationName)aName object:(id)anObject
+- (void)removeObserver:(id)observer name:(NSNotificationName)aName object:(nullable id)anObject
 {
     [NSNotificationCenter.defaultCenter removeObserver:observer name:aName object:anObject];
 }
@@ -77,7 +77,7 @@ - (void)removeObserver:(id)observer
     [NSNotificationCenter.defaultCenter removeObserver:observer];
 }
 
-- (void)postNotificationName:(NSNotificationName)aName object:(id)anObject
+- (void)postNotificationName:(NSNotificationName)aName object:(nullable id)anObject
 {
     [NSNotificationCenter.defaultCenter postNotificationName:aName object:anObject];
 }