test: Use non optional data for string to data (#5028)

Prefer using Data(foo.utf8) over using foo.data(using: .utf8)

Author: philipphofmann

Tests/SentryTests/Helper/SentryFileManagerTestExtension.swift

@@ -9,8 +9,8 @@ extension SentryFileManager {
     static func prepareInitError() {
         deleteInternalPath()
         do {
-            let data = "hello".data(using: .utf8)
-            try data?.write(to: getInternalPath())
+            let data = Data("hello".utf8)
+            try data.write(to: getInternalPath())
         } catch {
             XCTFail("Couldn't create file for init error of SentryFileManager.")
         }

Tests/SentryTests/Helper/SentryFileManagerTests.swift

@@ -182,7 +182,7 @@ class SentryFileManagerTests: XCTestCase {
 
         let dsStoreFile = "\(sut.basePath)/.DS_Store"
 
-        let result = FileManager.default.createFile(atPath: dsStoreFile, contents: "some data".data(using: .utf8))
+        let result = FileManager.default.createFile(atPath: dsStoreFile, contents: Data("some data".utf8))
         XCTAssertEqual(result, true)
 
         sut.deleteOldEnvelopeItems()
@@ -205,7 +205,7 @@ class SentryFileManagerTests: XCTestCase {
 
         let textFilePath = "\(sut.basePath)/something.txt"
 
-        let result = FileManager.default.createFile(atPath: textFilePath, contents: "some data".data(using: .utf8))
+        let result = FileManager.default.createFile(atPath: textFilePath, contents: Data("some data".utf8))
         XCTAssertEqual(result, true)
 
         sut.deleteOldEnvelopeItems()
@@ -785,8 +785,8 @@ class SentryFileManagerTests: XCTestCase {
         let fileManager = FileManager.default
         let appHangEventFilePath = try XCTUnwrap(Dynamic(sut).appHangEventFilePath.asString)
 
-        fileManager.createFile(atPath: appHangEventFilePath, contents: "garbage".data(using: .utf8)!, attributes: nil)
-        
+        fileManager.createFile(atPath: appHangEventFilePath, contents: Data("garbage".utf8), attributes: nil)
+
         // Act
         XCTAssertNil(sut.readAppHangEvent())
     }
@@ -822,8 +822,8 @@ class SentryFileManagerTests: XCTestCase {
         let fileManager = FileManager.default
         let appHangEventFilePath = try XCTUnwrap(Dynamic(sut).appHangEventFilePath.asString)
 
-        fileManager.createFile(atPath: appHangEventFilePath, contents: "garbage".data(using: .utf8)!, attributes: nil)
-        
+        fileManager.createFile(atPath: appHangEventFilePath, contents: Data("garbage".utf8), attributes: nil)
+
         // Act && Assert
         XCTAssertTrue(sut.appHangEventExists())
     }

Tests/SentryTests/Integrations/Performance/IO/DataSentryTracingIntegrationTests.swift

@@ -11,8 +11,8 @@ class DataSentryTracingIntegrationTests: XCTestCase {
             return provider
         }()
 
-        let data = "SOME DATA".data(using: .utf8)!
-        
+        let data = Data("SOME DATA".utf8)
+
         var fileUrlToRead: URL!
         var fileUrlToWrite: URL!
         var ignoredFileUrlToRead: URL!

Tests/SentryTests/Integrations/Performance/IO/FileManagerTracingIntegrationTests.swift

@@ -12,7 +12,7 @@ class FileManagerSentryTracingIntegrationTests: XCTestCase {
             return provider
         }()
 
-        let data = "SOME DATA".data(using: .utf8)!
+        let data = Data("SOME DATA".utf8)
 
         var fileSrcUrl: URL!
         var fileDestUrl: URL!

Tests/SentryTests/Integrations/Performance/IO/SentryFileIOTrackerTests.swift

@@ -11,7 +11,7 @@ class SentryFileIOTrackerTests: XCTestCase {
         let sentryPath = try! TestFileManager(options: Options()).sentryPath
         let sentryUrl = URL(fileURLWithPath: try! TestFileManager(options: Options()).sentryPath)
         let dateProvider = TestCurrentDateProvider()
-        let data = "SOME DATA".data(using: .utf8)!
+        let data = Data("SOME DATA".utf8)
         let threadInspector = TestThreadInspector.instance
         let imageProvider = TestDebugImageProvider()
 

Tests/SentryTests/Integrations/Performance/IO/SentryFileIOTrackingIntegrationTests.swift

@@ -6,7 +6,7 @@ import XCTest
 class SentryFileIOTrackingIntegrationTests: XCTestCase {
 
     private class Fixture {
-        let data = "SOME DATA".data(using: .utf8) ?? Data()
+        let data = Data("SOME DATA".utf8)
         let filePath: String!
         let fileURL: URL!
         let fileDirectory: URL!

Tests/SentryTests/Integrations/Performance/Network/SentryNetworkTrackerTests.swift

@@ -1011,13 +1011,13 @@ class SentryNetworkTrackerTests: XCTestCase {
             var request = $0
 
             request.httpMethod = "POST"
-            request.httpBody = """
+            request.httpBody = Data("""
             {
                 "operationName": "someOperationName",
                 "variables": { "a": 1 },
                 "query": "query someOperationName { someField }"
             }
-            """.data(using: .utf8)
+            """.utf8)
             request.allHTTPHeaderFields = ["content-type": "application/json"]
 
             return request

Tests/SentryTests/Integrations/SessionReplay/SentryOnDemandReplayTests.swift

@@ -165,7 +165,7 @@ class SentryOnDemandReplayTests: XCTestCase {
         let end = dateProvider.date()
 
         //Creating a file where the replay would be written to cause an error in the writer
-        try "tempFile".data(using: .utf8)?.write(to: outputPath.appendingPathComponent("0.0.mp4"))
+        try Data("tempFile".utf8).write(to: outputPath.appendingPathComponent("0.0.mp4"))
 
         XCTAssertThrowsError(try sut.createVideoWith(beginning: start, end: end))
     }

Tests/SentryTests/Integrations/ViewHierarchy/SentryViewHierarchyIntegrationTests.swift

@@ -11,7 +11,7 @@ class SentryViewHierarchyIntegrationTests: XCTestCase {
 
         init() {
             let testViewHierarchy = TestSentryViewHierarchy()
-            testViewHierarchy.result = "view hierarchy".data(using: .utf8) ?? Data()
+            testViewHierarchy.result = Data("view hierarchy".utf8)
             viewHierarchy = testViewHierarchy
         }
 

Tests/SentryTests/PrivateSentrySDKOnlyTests.swift

@@ -117,12 +117,12 @@ class PrivateSentrySDKOnlyTests: XCTestCase {
     }
 
     func testEnvelopeWithData() throws {
-        let itemData = "{}\n{\"length\":0,\"type\":\"attachment\"}\n".data(using: .utf8)!
+        let itemData = Data("{}\n{\"length\":0,\"type\":\"attachment\"}\n".utf8)
         XCTAssertNotNil(PrivateSentrySDKOnly.envelope(with: itemData))
     }
 
     func testEnvelopeWithDataLengthGtZero() throws {
-        let itemData = "{}\n{\"length\":1,\"type\":\"attachment\"}\n".data(using: .utf8)!
+        let itemData = Data("{}\n{\"length\":1,\"type\":\"attachment\"}\n".utf8)
         XCTAssertNil(PrivateSentrySDKOnly.envelope(with: itemData))
     }