fix: Don't send error 429 as network_error (#1957)

The docs state that errors with status code 429 should not be sent as network_error. The SDK didn't follow this rule yet.

Author: kevinrenskers

CHANGELOG.md

@@ -5,6 +5,7 @@
 ### Fixes
 
 - Properly sanitize the event context and SDK information (#1943)
+- Don't send error 429 as `network_error` (#1957)
 
 ## 7.20.0
 

Sources/Sentry/SentryHttpTransport.m

@@ -225,7 +225,7 @@ - (void)sendEnvelope:(SentryEnvelope *)envelope
                addRequest:request
         completionHandler:^(NSHTTPURLResponse *_Nullable response, NSError *_Nullable error) {
             // If the response is not nil we had an internet connection.
-            if (error) {
+            if (error && response.statusCode != 429) {
                 [_self recordLostEventFor:envelope.items];
             }
 

Tests/SentryTests/Networking/SentryHttpTransportTests.swift

@@ -287,19 +287,25 @@ class SentryHttpTransportTests: XCTestCase {
     }
 
     func testSendEventWithRetryAfterResponse() {
+        fixture.requestManager.nextError = NSError(domain: "something", code: 12)
+        
         let response = givenRetryAfterResponse()
 
         sendEvent()
 
         assertRateLimitUpdated(response: response)
+        assertClientReportNotStoredInMemory()
     }
 
     func testSendEventWithRateLimitResponse() {
+        fixture.requestManager.nextError = NSError(domain: "something", code: 12)
+
         let response = givenRateLimitResponse(forCategory: SentryEnvelopeItemTypeSession)
 
         sendEvent()
 
         assertRateLimitUpdated(response: response)
+        assertClientReportStoredInMemory()
     }
 
     func testSendEnvelopeWithRetryAfterResponse() {