fix: Remove property that had no effect

Author: noahsmartin

CHANGELOG.md

@@ -17,6 +17,7 @@
 - Makes `SentryEventDecodable` internal (#5808)
 - The `span` property on `SentryScope` is now readonly (#5866)
 - Removes deprecated SentryDebugImageProvider class (#5598)
+- Removes the SentryOptions.inAppExclude property because it had no effect (#6646)
 - Removes segment property on SentryUser, SentryBaggage, and SentryTraceContext (#5638)
 - Removes deprecated TraceContext initializers (#6348)
 - Removes deprecated user feedback API, this is replaced with the new feedback API (#5591)

Sources/Sentry/Public/SentryOptions.h

@@ -460,21 +460,6 @@ NS_SWIFT_NAME(Options)
  */
 - (void)addInAppInclude:(NSString *)inAppInclude;
 
-/**
- * A list of string prefixes of framework names that do not belong to the app, but rather to
- * third-party frameworks.
- * @note By default, frameworks considered not part of the app will be hidden from stack
- * traces.
- * @note This option can be overridden using @c inAppIncludes.
- */
-@property (nonatomic, readonly, copy) NSArray<NSString *> *inAppExcludes;
-
-/**
- * Adds an item to the list of @c inAppExcludes.
- * @param inAppExclude The prefix of the frameworks name.
- */
-- (void)addInAppExclude:(NSString *)inAppExclude;
-
 /**
  * Set as delegate on the @c NSURLSession used for all network data-transfer tasks performed by
  * Sentry.

Sources/Sentry/SentryCrashIntegration.m

@@ -145,8 +145,7 @@ - (void)startCrashHandler:(NSString *)cacheDirectory
         BOOL canSendReports = NO;
         if (installation == nil) {
             SentryInAppLogic *inAppLogic =
-                [[SentryInAppLogic alloc] initWithInAppIncludes:self.options.inAppIncludes
-                                                  inAppExcludes:self.options.inAppExcludes];
+                [[SentryInAppLogic alloc] initWithInAppIncludes:self.options.inAppIncludes];
 
             installation = [[SentryCrashInstallationReporter alloc]
                 initWithInAppLogic:inAppLogic

Sources/Sentry/SentryDefaultThreadInspector.m

@@ -69,8 +69,7 @@ - (id)initWithStacktraceBuilder:(SentryStacktraceBuilder *)stacktraceBuilder
 - (instancetype)initWithOptions:(SentryOptions *_Nullable)options
 {
     SentryInAppLogic *inAppLogic =
-        [[SentryInAppLogic alloc] initWithInAppIncludes:options.inAppIncludes ?: @[]
-                                          inAppExcludes:options.inAppExcludes ?: @[]];
+        [[SentryInAppLogic alloc] initWithInAppIncludes:options.inAppIncludes ?: @[]];
     SentryCrashStackEntryMapper *crashStackEntryMapper =
         [[SentryCrashStackEntryMapper alloc] initWithInAppLogic:inAppLogic];
     SentryStacktraceBuilder *stacktraceBuilder =

Sources/Sentry/SentryMetricKitIntegration.m

@@ -67,8 +67,7 @@ - (BOOL)installWithOptions:(SentryOptions *)options
     self.measurementFormatter = [[NSMeasurementFormatter alloc] init];
     self.measurementFormatter.locale = [[NSLocale alloc] initWithLocaleIdentifier:@"en_US"];
     self.measurementFormatter.unitOptions = NSMeasurementFormatterUnitOptionsProvidedUnit;
-    self.inAppLogic = [[SentryInAppLogic alloc] initWithInAppIncludes:options.inAppIncludes
-                                                        inAppExcludes:options.inAppExcludes];
+    self.inAppLogic = [[SentryInAppLogic alloc] initWithInAppIncludes:options.inAppIncludes];
     self.attachDiagnosticAsAttachment = options.enableMetricKitRawPayload;
 
     return YES;

Sources/Sentry/SentryOptions.m

@@ -152,8 +152,6 @@ - (instancetype)init
             _inAppIncludes = @[ bundleExecutable ];
         }
 
-        _inAppExcludes = [NSArray new];
-
         // Set default release name
         if (infoDict != nil) {
             self.releaseName =
@@ -229,11 +227,6 @@ - (void)addInAppInclude:(NSString *)inAppInclude
     _inAppIncludes = [self.inAppIncludes arrayByAddingObject:inAppInclude];
 }
 
-- (void)addInAppExclude:(NSString *)inAppExclude
-{
-    _inAppExcludes = [self.inAppExcludes arrayByAddingObject:inAppExclude];
-}
-
 - (void)setSampleRate:(NSNumber *)sampleRate
 {
     if (sampleRate == nil) {

Sources/Sentry/SentryOptionsInternal.m

@@ -311,14 +311,6 @@ + (BOOL)validateOptions:(NSDictionary<NSString *, id> *)options
         }
     }
 
-    if ([options[@"inAppExcludes"] isKindOfClass:[NSArray class]]) {
-        NSArray<NSString *> *inAppExcludes =
-            [options[@"inAppExcludes"] filteredArrayUsingPredicate:isNSString];
-        for (NSString *exclude in inAppExcludes) {
-            [sentryOptions addInAppExclude:exclude];
-        }
-    }
-
     if ([options[@"urlSession"] isKindOfClass:[NSURLSession class]]) {
         sentryOptions.urlSession = options[@"urlSession"];
     }

Sources/Sentry/SentryUIViewControllerSwizzling.m

@@ -51,8 +51,7 @@ - (instancetype)initWithOptions:(SentryOptions *)options
 {
     if (self = [super init]) {
         self.options = options;
-        self.inAppLogic = [[SentryInAppLogic alloc] initWithInAppIncludes:options.inAppIncludes
-                                                            inAppExcludes:options.inAppExcludes];
+        self.inAppLogic = [[SentryInAppLogic alloc] initWithInAppIncludes:options.inAppIncludes];
         self.dispatchQueue = dispatchQueue;
         self.objcRuntimeWrapper = objcRuntimeWrapper;
         self.subClassFinder = subClassFinder;

Sources/Swift/Core/Helper/SentryInAppLogic.swift

@@ -28,23 +28,17 @@ import ObjectiveC
 @objc @_spi(Private) public class SentryInAppLogic: NSObject {
 
     @objc public let inAppIncludes: [String]
-    private let inAppExcludes: [String]
 
     /**
-     * Initializes @c SentryInAppLogic with @c inAppIncludes and @c inAppExcludes.
+     * Initializes @c SentryInAppLogic with @c inAppIncludes.
      *
      * To work properly for Apple applications the @c inAppIncludes should contain the
      * @c CFBundleExecutable, which is the name of the bundle's executable file.
      *
-     * @param inAppIncludes A list of string prefixes of framework names that belong to the app. This
-     * option takes precedence over @c inAppExcludes.
-     * @param inAppExcludes A list of string prefixes of framework names that do not belong to the app,
-     * but rather to third-party packages. Modules considered not part of the app will be hidden from
-     * stack traces by default.
+     * @param inAppIncludes A list of string prefixes of framework names that belong to the app.
      */
-    @objc(initWithInAppIncludes:inAppExcludes:) public init(inAppIncludes: [String], inAppExcludes: [String]) {
+    @objc(initWithInAppIncludes:) public init(inAppIncludes: [String]) {
         self.inAppIncludes = inAppIncludes.map { $0.lowercased() }
-        self.inAppExcludes = inAppExcludes.map { $0.lowercased() }
         super.init()
     }
 
@@ -72,12 +66,6 @@ import ObjectiveC
             }
         }
 
-        for inAppExclude in inAppExcludes {
-            if imageNameLastPathComponent.hasPrefix(inAppExclude) {
-                return false
-            }
-        }
-        
         return false
     }
 

Sources/Swift/Integrations/Performance/SentryUIViewControllerPerformanceTracker.swift

@@ -27,7 +27,7 @@ import UIKit
 
     override init() {
         let options = SentrySDKInternal.options
-        inAppLogic = SentryInAppLogic(inAppIncludes: options?.inAppIncludes ?? [], inAppExcludes: options?.inAppExcludes ?? [])
+        inAppLogic = SentryInAppLogic(inAppIncludes: options?.inAppIncludes ?? [])
         helper = SentryDefaultUIViewControllerPerformanceTracker(tracker: SentryPerformanceTracker.shared)
     }