fix: Address review feedback for standalone app start tracing

- Fix trailing slash typo in changelog entry
- Restore enableUncaughtNSExceptionReporting in sample app
- Make StandaloneAppStartTransactionHelper final
- Add test for unknown app start type in StandaloneTransactionStrategy
- Restore visionOS platform guard in measurement provider tests
- Rename tests to follow test_when_should convention
- Remove extra blank line in sentryBuildAppStartSpansInternal

Author: philipphofmann

CHANGELOG.md

@@ -4,7 +4,7 @@
 
 ### Features
 
-- Add standalone app start tracing as an experimental option (#7660), enable it via `options.experimental.enableStandaloneAppStartTracing = true`/
+- Add standalone app start tracing as an experimental option (#7660), enable it via `options.experimental.enableStandaloneAppStartTracing = true`
 
 ## 9.7.0
 

Samples/SentrySampleShared/SentrySampleShared/SentrySDKWrapper.swift

@@ -182,6 +182,10 @@ public struct SentrySDKWrapper {
         options.enableFileManagerSwizzling = !SentrySDKOverrides.Other.disableFileManagerSwizzling.boolValue
         options.experimental.enableUnhandledCPPExceptionsV2 = true
         options.experimental.enableStandaloneAppStartTracing = true
+
+#if os(macOS) && !SENTRY_NO_UI_FRAMEWORK
+        options.enableUncaughtNSExceptionReporting = true
+#endif
     }
 
     func configureInitialScope(scope: Scope, options: Options) -> Scope {

Sources/Sentry/SentryBuildAppStartSpans.m

@@ -39,7 +39,6 @@
 sentryBuildAppStartSpansInternal(SentryTracer *tracer,
     SentryAppStartMeasurement *_Nullable appStartMeasurement, BOOL isStandalone)
 {
-
     if (appStartMeasurement == nil) {
         return @[];
     }

Sources/Swift/Integrations/AppStartTracking/AppStartReportingStrategy.swift

@@ -2,6 +2,7 @@
 
 #if (os(iOS) || os(tvOS) || os(visionOS)) && !SENTRY_NO_UI_FRAMEWORK
 
+/// Determines how a completed app start measurement is reported to Sentry.
 protocol AppStartReportingStrategy {
     func report(_ measurement: SentryAppStartMeasurement)
 }
@@ -61,7 +62,7 @@ struct StandaloneTransactionStrategy: AppStartReportingStrategy {
 }
 
 /// Helper to identify standalone app start transactions from ObjC code.
-@_spi(Private) @objc public class StandaloneAppStartTransactionHelper: NSObject {
+@_spi(Private) @objc public final class StandaloneAppStartTransactionHelper: NSObject {
     /// Returns `true` when the operation and origin match a standalone app start transaction.
     @objc public static func isStandaloneAppStartTransaction(operation: String, origin: String) -> Bool {
         return (operation == SentrySpanOperationAppStartCold

Tests/SentryTests/Integrations/Performance/AppStartTracking/AppStartReportingStrategyTests.swift

@@ -39,7 +39,7 @@ class AppStartReportingStrategyTests: XCTestCase {
 
     // MARK: - AttachToTransactionStrategy
 
-    func testAttach_SetsMeasurementOnGlobalStatic() throws {
+    func testReport_whenColdStart_shouldSetMeasurementOnGlobalStatic() throws {
         let measurement = createMeasurement(type: .cold)
 
         AttachToTransactionStrategy().report(measurement)
@@ -49,7 +49,7 @@ class AppStartReportingStrategyTests: XCTestCase {
         XCTAssertEqual(stored.duration, measurement.duration)
     }
 
-    func testAttach_WarmStart_SetsMeasurementOnGlobalStatic() throws {
+    func testReport_whenWarmStart_shouldSetMeasurementOnGlobalStatic() throws {
         let measurement = createMeasurement(type: .warm)
 
         AttachToTransactionStrategy().report(measurement)
@@ -60,7 +60,7 @@ class AppStartReportingStrategyTests: XCTestCase {
 
     // MARK: - StandaloneTransactionStrategy
 
-    func testSendStandalone_SDKNotEnabled_DoesNotCaptureTransaction() {
+    func testReport_whenSDKNotEnabled_shouldNotCaptureTransaction() {
         let hub = createHub()
         // Don't set hub on SDK — isEnabled returns false
         let measurement = createMeasurement(type: .cold)
@@ -70,7 +70,7 @@ class AppStartReportingStrategyTests: XCTestCase {
         XCTAssertTrue(hub.capturedEventsWithScopes.invocations.isEmpty)
     }
 
-    func testSendStandalone_ColdStart_CapturesTransaction() throws {
+    func testReport_whenColdStart_shouldCaptureTransaction() throws {
         let hub = createHub()
         SentrySDKInternal.setCurrentHub(hub)
         let measurement = createMeasurement(type: .cold)
@@ -86,7 +86,7 @@ class AppStartReportingStrategyTests: XCTestCase {
         XCTAssertEqual(traceContext["origin"] as? String, "auto.app.start")
     }
 
-    func testSendStandalone_WarmStart_CapturesTransaction() throws {
+    func testReport_whenWarmStart_shouldCaptureTransaction() throws {
         let hub = createHub()
         SentrySDKInternal.setCurrentHub(hub)
         let measurement = createMeasurement(type: .warm)
@@ -101,7 +101,17 @@ class AppStartReportingStrategyTests: XCTestCase {
         XCTAssertEqual(traceContext["op"] as? String, "app.start.warm")
     }
 
-    func testSendStandalone_DoesNotSetGlobalStatic() {
+    func testReport_whenUnknownStartType_shouldNotCaptureTransaction() {
+        let hub = createHub()
+        SentrySDKInternal.setCurrentHub(hub)
+        let measurement = createMeasurement(type: .unknown)
+
+        StandaloneTransactionStrategy().report(measurement)
+
+        XCTAssertTrue(hub.capturedTransactionsWithScope.invocations.isEmpty)
+    }
+
+    func testReport_whenColdStart_shouldNotSetGlobalStatic() {
         let hub = createHub()
         SentrySDKInternal.setCurrentHub(hub)
         let measurement = createMeasurement(type: .cold)
@@ -135,7 +145,7 @@ class AppStartReportingStrategyTests: XCTestCase {
         return hub
     }
 
-    func testSendStandalone_ColdStart_AddsAppStartMeasurement() throws {
+    func testReport_whenColdStart_shouldAddAppStartMeasurement() throws {
         let hub = setUpIntegrationHub()
         let measurement = createMeasurement(type: .cold, duration: 0.5)
 
@@ -147,7 +157,7 @@ class AppStartReportingStrategyTests: XCTestCase {
         XCTAssertEqual(appStartCold["value"] as? Double, 500)
     }
 
-    func testSendStandalone_WarmStart_AddsAppStartMeasurement() throws {
+    func testReport_whenWarmStart_shouldAddAppStartMeasurement() throws {
         let hub = setUpIntegrationHub()
         let measurement = createMeasurement(type: .warm, duration: 0.3)
 
@@ -159,7 +169,7 @@ class AppStartReportingStrategyTests: XCTestCase {
         XCTAssertEqual(appStartWarm["value"] as? Double, 300)
     }
 
-    func testSendStandalone_AddsDebugMeta() throws {
+    func testReport_whenColdStart_shouldAddDebugMeta() throws {
         let hub = setUpIntegrationHub()
         let measurement = createMeasurement(type: .cold)
 
@@ -175,7 +185,7 @@ class AppStartReportingStrategyTests: XCTestCase {
         XCTAssertEqual(image["image_vmaddr"] as? String, expectedImage.imageVmAddress)
     }
 
-    func testSendStandalone_SetsStartTimeToAppStartTimestamp() throws {
+    func testReport_whenColdStart_shouldSetStartTimeToAppStartTimestamp() throws {
         let hub = setUpIntegrationHub()
         let measurement = createMeasurement(type: .cold)
 
@@ -192,7 +202,7 @@ class AppStartReportingStrategyTests: XCTestCase {
 
     /// Verifies the full span tree for a warm non-prewarmed standalone app start transaction.
     /// More span edge cases (cold, prewarmed, grouping span) are covered in SentryBuildAppStartSpansTests.
-    func testSendStandalone_WarmNotPrewarmed_ContainsCorrectSpans() throws {
+    func testReport_whenWarmNotPrewarmed_shouldContainCorrectSpans() throws {
         let hub = setUpIntegrationHub()
         let dateProvider = TestCurrentDateProvider()
         let appStart = dateProvider.date()
@@ -254,28 +264,28 @@ class AppStartReportingStrategyTests: XCTestCase {
 
     // MARK: - StandaloneAppStartTransactionHelper
 
-    func testHelper_ColdStartWithAutoOrigin_ReturnsTrue() {
+    func testIsStandaloneAppStartTransaction_whenColdStartWithAutoOrigin_shouldReturnTrue() {
         XCTAssertTrue(StandaloneAppStartTransactionHelper.isStandaloneAppStartTransaction(
             operation: "app.start.cold",
             origin: "auto.app.start"
         ))
     }
 
-    func testHelper_WarmStartWithAutoOrigin_ReturnsTrue() {
+    func testIsStandaloneAppStartTransaction_whenWarmStartWithAutoOrigin_shouldReturnTrue() {
         XCTAssertTrue(StandaloneAppStartTransactionHelper.isStandaloneAppStartTransaction(
             operation: "app.start.warm",
             origin: "auto.app.start"
         ))
     }
 
-    func testHelper_UILoadWithAutoOrigin_ReturnsFalse() {
+    func testIsStandaloneAppStartTransaction_whenUILoadWithAutoOrigin_shouldReturnFalse() {
         XCTAssertFalse(StandaloneAppStartTransactionHelper.isStandaloneAppStartTransaction(
             operation: "ui.load",
             origin: "auto.app.start"
         ))
     }
 
-    func testHelper_ColdStartWithManualOrigin_ReturnsFalse() {
+    func testIsStandaloneAppStartTransaction_whenColdStartWithManualOrigin_shouldReturnFalse() {
         XCTAssertFalse(StandaloneAppStartTransactionHelper.isStandaloneAppStartTransaction(
             operation: "app.start.cold",
             origin: "manual"

Tests/SentryTests/Integrations/Performance/AppStartTracking/SentryAppStartMeasurementProviderTests.swift

@@ -1,7 +1,7 @@
 @_spi(Private) @testable import Sentry
 import XCTest
 
-#if os(iOS) || os(tvOS)
+#if os(iOS) || os(tvOS) || os(visionOS)
 
 class SentryAppStartMeasurementProviderTests: XCTestCase {