Skip to content

Commit f9d45aa

Browse files
authored
Remove SentrySwiftLog Integration (#6738)
1 parent 8447671 commit f9d45aa

File tree

14 files changed

+7
-1773
lines changed

14 files changed

+7
-1773
lines changed

.github/file-filters.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -428,7 +428,6 @@ run_version_bump_util_for_prs: &run_version_bump_util_for_prs
428428
- "Sources/Configuration/SDK.xcconfig"
429429
- "Sources/Configuration/Versioning.xcconfig"
430430
- "Sources/Configuration/SentrySwiftUI.xcconfig"
431-
- "Sources/Configuration/SentrySwiftLog.xcconfig"
432431

433432
run_ui_tests_for_prs: &run_ui_tests_for_prs
434433
- "Sources/**"

.github/workflows/test.yml

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -355,16 +355,6 @@ jobs:
355355
device: "iPhone 15 Pro"
356356
scheme: "SentrySwiftUI"
357357

358-
# iOS 17 - Use pre-installed iOS 17.5 runtime on macOS-14 with Xcode 15.4
359-
- name: iOS 17 SentrySwiftLog
360-
runs-on: macos-14
361-
xcode: "15.4"
362-
test-destination-os: "17.5"
363-
platform: "iOS"
364-
create_device: true
365-
device: "iPhone 15 Pro"
366-
scheme: "SentrySwiftLog"
367-
368358
# tvOS 18
369359
- name: tvOS 18 Sentry
370360
runs-on: macos-15

CHANGELOG.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,6 @@
6363
This option is still disabled by default and will be enabled in a future major release.
6464
- Move `enableDataSwizzling` from experimental options to top-level options (#6592). This option remains enabled by default.
6565
- Add `sentry.replay_id` attribute to logs ([#6515](https://github.com/getsentry/sentry-cocoa/pull/6515))
66-
- Structured Logs: Add `SentrySwiftLog` Integration (#6286)
6766

6867
## 9.0.0-alpha.0
6968

@@ -127,7 +126,6 @@
127126
This option is still disabled by default and will be enabled in a future major release.
128127
- Move `enableDataSwizzling` from experimental options to top-level options (#6592). This option remains enabled by default.
129128
- Add `sentry.replay_id` attribute to logs ([#6515](https://github.com/getsentry/sentry-cocoa/pull/6515))
130-
- Structured Logs: Add `SentrySwiftLog` Integration (#6286)
131129

132130
## 8.57.2
133131

Package.swift

Lines changed: 2 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,7 @@ var products: [Product] = [
1616
.library(name: "Sentry-WithoutUIKitOrAppKit", targets: ["Sentry-WithoutUIKitOrAppKit", "SentryCppHelper"]),
1717
.library(name: "Sentry-WithoutUIKitOrAppKit-WithARM64e", targets: ["Sentry-WithoutUIKitOrAppKit-WithARM64e", "SentryCppHelper"]),
1818
.library(name: "SentrySwiftUI", targets: ["Sentry", "SentrySwiftUI", "SentryCppHelper"]),
19-
.library(name: "SentryDistribution", targets: ["SentryDistribution"]),
20-
.library(name: "SentrySwiftLog", targets: ["Sentry", "SentrySwiftLog"])
19+
.library(name: "SentryDistribution", targets: ["SentryDistribution"])
2120
]
2221

2322
var targets: [Target] = [
@@ -55,14 +54,6 @@ var targets: [Target] = [
5554
.linkedFramework("Sentry")
5655
]
5756
),
58-
.target(
59-
name: "SentrySwiftLog",
60-
dependencies: ["Sentry", .product(name: "Logging", package: "swift-log")],
61-
path: "Sources/SentrySwiftLog",
62-
linkerSettings: [
63-
.linkedFramework("Sentry")
64-
]
65-
),
6657
.target(
6758
name: "SentryInternal",
6859
path: "Sources/SentrySwiftUI",
@@ -112,7 +103,7 @@ if let env = env, String(cString: env, encoding: .utf8) == "1" {
112103
name: "SentryObjc",
113104
dependencies: ["SentrySwift"],
114105
path: "Sources",
115-
exclude: ["Sentry/SentryDummyPublicEmptyClass.m", "Sentry/SentryDummyPrivateEmptyClass.m", "Swift", "SentrySwiftUI", "SentrySwiftLog", "Resources", "Configuration", "SentryCppHelper", "SentryDistribution", "SentryDistributionTests"],
106+
exclude: ["Sentry/SentryDummyPublicEmptyClass.m", "Sentry/SentryDummyPrivateEmptyClass.m", "Swift", "SentrySwiftUI", "Resources", "Configuration", "SentryCppHelper", "SentryDistribution", "SentryDistributionTests"],
116107
cSettings: [
117108
.headerSearchPath("Sentry/include/HybridPublic"),
118109
.headerSearchPath("Sentry"),
@@ -129,12 +120,6 @@ let package = Package(
129120
name: "Sentry",
130121
platforms: [.iOS(.v15), .macOS(.v12), .tvOS(.v15), .watchOS(.v8)],
131122
products: products,
132-
dependencies: [
133-
// SPM doesn't support peer-dependencies, so users are locked into our declared version.
134-
// Using `from: "1.6.0"` covers 1.6.0 < 2.0.0, resolving minor versions automatically.
135-
// See develop-docs/DECISIONS.md for discussion.
136-
.package(url: "https://github.com/apple/swift-log", from: "1.6.0")
137-
],
138123
targets: targets,
139124
cxxLanguageStandard: .cxx14
140125
)

Plans/SentrySwiftLog_Base.xctestplan

Lines changed: 0 additions & 24 deletions
This file was deleted.

Samples/iOS-Swift/iOS-Swift.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ targets:
3434
- target: iOS-SwiftClip
3535
- target: SentrySampleShared/SentrySampleShared
3636
- target: iOS-Swift-ShareExtension
37-
- target: Sentry/SentrySwiftLog
3837
configFiles:
3938
Debug: iOS-Swift.xcconfig
4039
Release: iOS-Swift.xcconfig

Samples/iOS-Swift/iOS-Swift/AppDelegate.swift

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
11
import SentrySampleShared
22
import UIKit
33

4-
import Logging
5-
import SentrySwiftLog
6-
74
@UIApplicationMain
85
class AppDelegate: UIResponder, UIApplicationDelegate {
96
private var randomDistributionTimer: Timer?
@@ -32,17 +29,6 @@ class AppDelegate: UIResponder, UIApplicationDelegate {
3229
metricKit.receiveReports()
3330
}
3431

35-
// Use structured logs with swift-log
36-
LoggingSystem.bootstrap { _ in
37-
return SentryLogHandler(logLevel: .trace)
38-
}
39-
let logger = Logger(label: "io.sentry.iOS-Swift")
40-
logger.trace(
41-
"[iOS-Swift] didFinishLaunchingWithOptions",
42-
metadata: ["foo": "bar"],
43-
source: "iOS"
44-
)
45-
4632
return true
4733
}
4834

0 commit comments

Comments
 (0)