-
-
Notifications
You must be signed in to change notification settings - Fork 376
Closed
Description
Note
The pull request "ref: Renames SentrySpan class to SentrySpanInternal" was created by @itaybre but did not reference an issue. Therefore this issue was created for better visibility in external tools like Linear.
π Description
Renames the class SentrySpan to SentrySpanInternal, keeping SentrySpan only to the protocol.
Only the protocol is a public API, so no breaking changes were made
π‘ Motivation and Context
We have 2 types with identical names, one a protocol and another a class.
While converting the SentryCrashIntegration to Swift, I ran into issues with them having the same name in ObjC.
π How did you test it?
π Checklist
You have to check all boxes before merging:
- I added tests to verify the changes.
- No new PII added or SDK only sends newly added PII if
sendDefaultPIIis enabled. - I updated the docs if needed.
- I updated the wizard if needed.
- Review from the native team if needed.
- No breaking change or entry added to the changelog.
- No breaking change for hybrid SDKs or communicated to hybrid SDKs.
Metadata
Metadata
Assignees
Labels
No labels