Skip to content

chore: Remove profiling API deprecated in V9 #6386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

chore: Remove profiling API deprecated in V9 #6386

wants to merge 2 commits into from

Conversation

noahsmartin
Copy link
Contributor

#skip-changelog

@codecov Codecov
Copy link

codecov bot commented Oct 9, 2025 •
edited
Loading

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
3901 2 3899 28
View the top 2 failed test(s) by shortest run time 
SentryProfilerTests.SentryProfilingPublicAPITests::testStartingContinuousProfilerV2WithoutContinuousProfilingEnabledDoesNotStartProfiler
Stack Traces | 0s run time 
.../Tests/SentryProfilerTests/SentryProfilingPublicAPITests.swift:205 - XCTAssertFalse failed
iOS_SwiftUI_UITests.LaunchUITests::testTransactionSpan
Stack Traces | 0s run time 
.../iOS-SwiftUI/iOS-SwiftUI-UITests/LaunchUITests.swift:19 - Failed to get matching snapshots: Timed out while evaluating UI query.

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2025 •
edited
Loading

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1216.85 ms 1250.10 ms 33.25 ms
Size 23.75 KiB 1.00 MiB 1004.89 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
5ec90e0 1235.57 ms 1258.45 ms 22.88 ms
27e7514 1229.47 ms 1245.60 ms 16.13 ms
2a07609 1207.79 ms 1233.77 ms 25.98 ms
b13e93a 1236.24 ms 1247.33 ms 11.08 ms
304a921 1237.46 ms 1265.57 ms 28.12 ms
c174e5e 1209.65 ms 1238.73 ms 29.08 ms
035974f 1225.89 ms 1251.23 ms 25.34 ms
db9572a 1212.61 ms 1237.73 ms 25.13 ms
9cbff30 1236.33 ms 1254.35 ms 18.03 ms
f97a070 1218.88 ms 1253.12 ms 34.24 ms

App size

Revision Plain With Sentry Diff
5ec90e0 23.74 KiB 872.67 KiB 848.92 KiB
27e7514 23.75 KiB 919.69 KiB 895.94 KiB
2a07609 23.75 KiB 912.78 KiB 889.03 KiB
b13e93a 23.75 KiB 855.37 KiB 831.62 KiB
304a921 23.75 KiB 989.12 KiB 965.37 KiB
c174e5e 23.75 KiB 953.92 KiB 930.16 KiB
035974f 23.74 KiB 874.07 KiB 850.33 KiB
db9572a 23.75 KiB 858.65 KiB 834.90 KiB
9cbff30 23.75 KiB 928.15 KiB 904.40 KiB
f97a070 23.75 KiB 858.68 KiB 834.93 KiB

Previous results on branch: removeDeprecatedProfiling

Startup times

Revision Plain With Sentry Diff
9c83d7c 1226.31 ms 1255.61 ms 29.30 ms
71bc84c 1221.04 ms 1261.89 ms 40.85 ms
f5e2a65 1217.68 ms 1248.96 ms 31.28 ms
e1027c9 1236.31 ms 1271.68 ms 35.37 ms
d7174b5 1221.44 ms 1251.22 ms 29.79 ms

App size

Revision Plain With Sentry Diff
9c83d7c 23.75 KiB 987.76 KiB 964.01 KiB
71bc84c 23.75 KiB 1020.85 KiB 997.10 KiB
f5e2a65 23.75 KiB 1020.85 KiB 997.10 KiB
e1027c9 23.74 KiB 1021.80 KiB 998.05 KiB
d7174b5 23.75 KiB 1020.85 KiB 997.10 KiB

@noahsmartin noahsmartin force-pushed the removeDeprecatedProfiling branch 4 times, most recently from d67bb03 to 6fdf82d Compare October 19, 2025 21:40
@noahsmartin noahsmartin force-pushed the removeDeprecatedProfiling branch 6 times, most recently from 8dc06c6 to 24e9530 Compare October 21, 2025 21:23
@noahsmartin noahsmartin force-pushed the removeDeprecatedProfiling branch from 24e9530 to b5352cb Compare October 21, 2025 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@philipphofmann philipphofmann Awaiting requested review from philipphofmann philipphofmann will be requested when the pull request is marked ready for review philipphofmann is a code owner

@philprime philprime Awaiting requested review from philprime philprime will be requested when the pull request is marked ready for review philprime is a code owner

@itaybre itaybre Awaiting requested review from itaybre itaybre will be requested when the pull request is marked ready for review itaybre is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@noahsmartin