Skip to content

Commit 5d07961

Browse files
loewenheimloewenheim
authored
feat(sentry): Add sentry.browser.name/version (#139)
1 parent 74d6eea commit 5d07961

File tree

8 files changed

+146
-2
lines changed

8 files changed

+146
-2
lines changed

‎generated/attributes/browser.md‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ The name of the browser.
2222
| Has PII | maybe |
2323
| Exists in OpenTelemetry | No |
2424
| Example | `Chrome` |
25+
| Aliases | `sentry.browser.name` |
2526

2627
### browser.report.type
2728

@@ -77,4 +78,5 @@ The version of the browser.
7778
| Has PII | maybe |
7879
| Exists in OpenTelemetry | No |
7980
| Example | `120.0.6099.130` |
81+
| Aliases | `sentry.browser.version` |
8082

‎generated/attributes/sentry.md‎

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,8 @@
3232
- [sentry.trace.parent_span_id](#sentrytraceparent_span_id)
3333
- [sentry.transaction](#sentrytransaction)
3434
- [Deprecated Attributes](#deprecated-attributes)
35+
- [sentry.browser.name](#sentrybrowsername)
36+
- [sentry.browser.version](#sentrybrowserversion)
3537
- [sentry.segment_id](#sentrysegment_id)
3638

3739
## Stable Attributes
@@ -355,6 +357,32 @@ The sentry transaction (segment name).
355357

356358
These attributes are deprecated and will be removed in a future version. Please use the recommended replacements.
357359

360+
### sentry.browser.name
361+
362+
The name of the browser.
363+
364+
| Property | Value |
365+
| --- | --- |
366+
| Type | `string` |
367+
| Has PII | maybe |
368+
| Exists in OpenTelemetry | No |
369+
| Example | `Chrome` |
370+
| Deprecated | Yes, use `browser.name` instead |
371+
| Aliases | `browser.name` |
372+
373+
### sentry.browser.version
374+
375+
The version of the browser.
376+
377+
| Property | Value |
378+
| --- | --- |
379+
| Type | `string` |
380+
| Has PII | maybe |
381+
| Exists in OpenTelemetry | No |
382+
| Example | `120.0.6099.130` |
383+
| Deprecated | Yes, use `browser.version` instead |
384+
| Aliases | `browser.version` |
385+
358386
### sentry.segment_id
359387

360388
The segment ID of a span

‎javascript/sentry-conventions/src/attributes.ts‎

Lines changed: 52 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -765,6 +765,8 @@ export type BLOCKED_MAIN_THREAD_TYPE = boolean;
765765
*
766766
* Attribute defined in OTEL: No
767767
*
768+
* Aliases: {@link SENTRY_BROWSER_NAME} `sentry.browser.name`
769+
*
768770
* @example "Chrome"
769771
*/
770772
export const BROWSER_NAME = 'browser.name';
@@ -865,6 +867,8 @@ export type BROWSER_SCRIPT_SOURCE_CHAR_POSITION_TYPE = number;
865867
*
866868
* Attribute defined in OTEL: No
867869
*
870+
* Aliases: {@link SENTRY_BROWSER_VERSION} `sentry.browser.version`
871+
*
868872
* @example "120.0.6099.130"
869873
*/
870874
export const BROWSER_VERSION = 'browser.version';
@@ -5324,6 +5328,52 @@ export const RPC_SERVICE = 'rpc.service';
53245328
*/
53255329
export type RPC_SERVICE_TYPE = string;
53265330

5331+
// Path: model/attributes/sentry/sentry__browser__name.json
5332+
5333+
/**
5334+
* The name of the browser. `sentry.browser.name`
5335+
*
5336+
* Attribute Value Type: `string` {@link SENTRY_BROWSER_NAME_TYPE}
5337+
*
5338+
* Contains PII: maybe
5339+
*
5340+
* Attribute defined in OTEL: No
5341+
*
5342+
* Aliases: {@link BROWSER_NAME} `browser.name`
5343+
*
5344+
* @deprecated Use {@link BROWSER_NAME} (browser.name) instead
5345+
* @example "Chrome"
5346+
*/
5347+
export const SENTRY_BROWSER_NAME = 'sentry.browser.name';
5348+
5349+
/**
5350+
* Type for {@link SENTRY_BROWSER_NAME} sentry.browser.name
5351+
*/
5352+
export type SENTRY_BROWSER_NAME_TYPE = string;
5353+
5354+
// Path: model/attributes/sentry/sentry__browser__version.json
5355+
5356+
/**
5357+
* The version of the browser. `sentry.browser.version`
5358+
*
5359+
* Attribute Value Type: `string` {@link SENTRY_BROWSER_VERSION_TYPE}
5360+
*
5361+
* Contains PII: maybe
5362+
*
5363+
* Attribute defined in OTEL: No
5364+
*
5365+
* Aliases: {@link BROWSER_VERSION} `browser.version`
5366+
*
5367+
* @deprecated Use {@link BROWSER_VERSION} (browser.version) instead
5368+
* @example "120.0.6099.130"
5369+
*/
5370+
export const SENTRY_BROWSER_VERSION = 'sentry.browser.version';
5371+
5372+
/**
5373+
* Type for {@link SENTRY_BROWSER_VERSION} sentry.browser.version
5374+
*/
5375+
export type SENTRY_BROWSER_VERSION_TYPE = string;
5376+
53275377
// Path: model/attributes/sentry/sentry__cancellation_reason.json
53285378

53295379
/**
@@ -7108,6 +7158,8 @@ export type FullAttributes = {
71087158
[ROUTE]?: ROUTE_TYPE;
71097159
[RPC_GRPC_STATUS_CODE]?: RPC_GRPC_STATUS_CODE_TYPE;
71107160
[RPC_SERVICE]?: RPC_SERVICE_TYPE;
7161+
[SENTRY_BROWSER_NAME]?: SENTRY_BROWSER_NAME_TYPE;
7162+
[SENTRY_BROWSER_VERSION]?: SENTRY_BROWSER_VERSION_TYPE;
71117163
[SENTRY_CANCELLATION_REASON]?: SENTRY_CANCELLATION_REASON_TYPE;
71127164
[SENTRY_CLIENT_SAMPLE_RATE]?: SENTRY_CLIENT_SAMPLE_RATE_TYPE;
71137165
[SENTRY_DESCRIPTION]?: SENTRY_DESCRIPTION_TYPE;

‎model/attributes/browser/browser__name.json‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,5 +6,6 @@
66
"key": "maybe"
77
},
88
"is_in_otel": false,
9-
"example": "Chrome"
9+
"example": "Chrome",
10+
"alias": ["sentry.browser.name"]
1011
}

‎model/attributes/browser/browser__version.json‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,5 +6,6 @@
66
"key": "maybe"
77
},
88
"is_in_otel": false,
9-
"example": "120.0.6099.130"
9+
"example": "120.0.6099.130",
10+
"alias": ["sentry.browser.version"]
1011
}

‎model/attributes/sentry/sentry__browser__name.json‎

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
{
2+
"key": "sentry.browser.name",
3+
"brief": "The name of the browser.",
4+
"type": "string",
5+
"pii": {
6+
"key": "maybe"
7+
},
8+
"is_in_otel": false,
9+
"example": "Chrome",
10+
"deprecation": {
11+
"_status": null,
12+
"replacement": "browser.name"
13+
},
14+
"alias": ["browser.name"]
15+
}

‎model/attributes/sentry/sentry__browser__version.json‎

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
{
2+
"key": "sentry.browser.version",
3+
"brief": "The version of the browser.",
4+
"type": "string",
5+
"pii": {
6+
"key": "maybe"
7+
},
8+
"is_in_otel": false,
9+
"example": "120.0.6099.130",
10+
"deprecation": {
11+
"_status": null,
12+
"replacement": "browser.version"
13+
},
14+
"alias": ["browser.version"]
15+
}

‎shared/deprecated_attributes.json‎

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1058,6 +1058,36 @@
10581058
},
10591059
"example": "query.id='123'"
10601060
},
1061+
{
1062+
"key": "sentry.browser.name",
1063+
"brief": "The name of the browser.",
1064+
"type": "string",
1065+
"pii": {
1066+
"key": "maybe"
1067+
},
1068+
"is_in_otel": false,
1069+
"example": "Chrome",
1070+
"deprecation": {
1071+
"_status": null,
1072+
"replacement": "browser.name"
1073+
},
1074+
"alias": ["browser.name"]
1075+
},
1076+
{
1077+
"key": "sentry.browser.version",
1078+
"brief": "The version of the browser.",
1079+
"type": "string",
1080+
"pii": {
1081+
"key": "maybe"
1082+
},
1083+
"is_in_otel": false,
1084+
"example": "120.0.6099.130",
1085+
"deprecation": {
1086+
"_status": null,
1087+
"replacement": "browser.version"
1088+
},
1089+
"alias": ["browser.version"]
1090+
},
10611091
{
10621092
"key": "sentry.segment_id",
10631093
"brief": "The segment ID of a span",

0 commit comments

Comments
 (0)