Skip to content

Commit b056c89

Browse files
authored
feat(attributes): Backfill db.system attribute (#224)
Insights's Queries module currently depends on db.system rather than its replacement, db.system.name. By setting its deprecation status to backfill, Relay won't remove db.system from incoming spans and will automatically write db.system when db.system.name is received.
1 parent 5eac935 commit b056c89

File tree

4 files changed

+4
-3
lines changed

4 files changed

+4
-3
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
- feat(attributes): Add sentry.normalized_db_query.hash ([#200](https://github.com/getsentry/sentry-conventions/pull/200))
1111
- feat(attributes): Add sentry.category attribute ([#218](https://github.com/getsentry/sentry-conventions/pull/218))
1212
- Add new Gen AI attributes ([#221](https://github.com/getsentry/sentry-conventions/pull/221))
13+
- Backfill `db.system` attribute ([#224](https://github.com/getsentry/sentry-conventions/pull/224))
1314

1415
## 0.3.1
1516

model/attributes/db/db__system.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
"is_in_otel": true,
99
"example": "postgresql",
1010
"deprecation": {
11-
"_status": "normalize",
11+
"_status": "backfill",
1212
"replacement": "db.system.name"
1313
},
1414
"alias": ["db.system.name"]

python/src/sentry_conventions/attributes.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5405,7 +5405,7 @@ class ATTRIBUTE_NAMES(metaclass=_AttributeNamesMeta):
54055405
is_in_otel=True,
54065406
example="postgresql",
54075407
deprecation=DeprecationInfo(
5408-
replacement="db.system.name", status=DeprecationStatus.NORMALIZE
5408+
replacement="db.system.name", status=DeprecationStatus.BACKFILL
54095409
),
54105410
aliases=["db.system.name"],
54115411
),

shared/deprecated_attributes.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -575,7 +575,7 @@
575575
"is_in_otel": true,
576576
"example": "postgresql",
577577
"deprecation": {
578-
"_status": "normalize",
578+
"_status": "backfill",
579579
"replacement": "db.system.name"
580580
},
581581
"alias": ["db.system.name"]

0 commit comments

Comments
 (0)