Skip to content

Commit f053b1d

Browse files
authored
feat: Remove sentry.profile_id and profile_id attributes (#256)
1 parent e825962 commit f053b1d

File tree

5 files changed

+0
-158
lines changed

5 files changed

+0
-158
lines changed

javascript/sentry-conventions/src/attributes.ts

Lines changed: 0 additions & 74 deletions
Original file line numberDiff line numberDiff line change
@@ -6219,29 +6219,6 @@ export const PROCESS_RUNTIME_VERSION = 'process.runtime.version';
62196219
*/
62206220
export type PROCESS_RUNTIME_VERSION_TYPE = string;
62216221

6222-
// Path: model/attributes/profile_id.json
6223-
6224-
/**
6225-
* The id of the sentry profile. `profile_id`
6226-
*
6227-
* Attribute Value Type: `string` {@link PROFILE_ID_TYPE}
6228-
*
6229-
* Contains PII: false
6230-
*
6231-
* Attribute defined in OTEL: No
6232-
*
6233-
* Aliases: {@link SENTRY_PROFILE_ID} `sentry.profile_id`
6234-
*
6235-
* @deprecated Use {@link SENTRY_PROFILE_ID} (sentry.profile_id) instead
6236-
* @example "123e4567e89b12d3a456426614174000"
6237-
*/
6238-
export const PROFILE_ID = 'profile_id';
6239-
6240-
/**
6241-
* Type for {@link PROFILE_ID} profile_id
6242-
*/
6243-
export type PROFILE_ID_TYPE = string;
6244-
62456222
// Path: model/attributes/query/query__[key].json
62466223

62476224
/**
@@ -7183,28 +7160,6 @@ export const SENTRY_PROFILER_ID = 'sentry.profiler_id';
71837160
*/
71847161
export type SENTRY_PROFILER_ID_TYPE = string;
71857162

7186-
// Path: model/attributes/sentry/sentry__profile_id.json
7187-
7188-
/**
7189-
* The id of the sentry profile. `sentry.profile_id`
7190-
*
7191-
* Attribute Value Type: `string` {@link SENTRY_PROFILE_ID_TYPE}
7192-
*
7193-
* Contains PII: false
7194-
*
7195-
* Attribute defined in OTEL: No
7196-
*
7197-
* Aliases: {@link PROFILE_ID} `profile_id`
7198-
*
7199-
* @example "123e4567e89b12d3a456426614174000"
7200-
*/
7201-
export const SENTRY_PROFILE_ID = 'sentry.profile_id';
7202-
7203-
/**
7204-
* Type for {@link SENTRY_PROFILE_ID} sentry.profile_id
7205-
*/
7206-
export type SENTRY_PROFILE_ID_TYPE = string;
7207-
72087163
// Path: model/attributes/sentry/sentry__release.json
72097164

72107165
/**
@@ -9266,7 +9221,6 @@ export const ATTRIBUTE_TYPE: Record<string, AttributeType> = {
92669221
[PROCESS_RUNTIME_DESCRIPTION]: 'string',
92679222
[PROCESS_RUNTIME_NAME]: 'string',
92689223
[PROCESS_RUNTIME_VERSION]: 'string',
9269-
[PROFILE_ID]: 'string',
92709224
[QUERY_KEY]: 'string',
92719225
[RELEASE]: 'string',
92729226
[REMIX_ACTION_FORM_DATA_KEY]: 'string',
@@ -9313,7 +9267,6 @@ export const ATTRIBUTE_TYPE: Record<string, AttributeType> = {
93139267
[SENTRY_ORIGIN]: 'string',
93149268
[SENTRY_PLATFORM]: 'string',
93159269
[SENTRY_PROFILER_ID]: 'string',
9316-
[SENTRY_PROFILE_ID]: 'string',
93179270
[SENTRY_RELEASE]: 'string',
93189271
[SENTRY_REPLAY_ID]: 'string',
93199272
[SENTRY_REPLAY_IS_BUFFERING]: 'boolean',
@@ -9699,7 +9652,6 @@ export type AttributeName =
96999652
| typeof PROCESS_RUNTIME_DESCRIPTION
97009653
| typeof PROCESS_RUNTIME_NAME
97019654
| typeof PROCESS_RUNTIME_VERSION
9702-
| typeof PROFILE_ID
97039655
| typeof QUERY_KEY
97049656
| typeof RELEASE
97059657
| typeof REMIX_ACTION_FORM_DATA_KEY
@@ -9746,7 +9698,6 @@ export type AttributeName =
97469698
| typeof SENTRY_ORIGIN
97479699
| typeof SENTRY_PLATFORM
97489700
| typeof SENTRY_PROFILER_ID
9749-
| typeof SENTRY_PROFILE_ID
97509701
| typeof SENTRY_RELEASE
97519702
| typeof SENTRY_REPLAY_ID
97529703
| typeof SENTRY_REPLAY_IS_BUFFERING
@@ -12951,19 +12902,6 @@ export const ATTRIBUTE_METADATA: Record<AttributeName, AttributeMetadata> = {
1295112902
isInOtel: true,
1295212903
example: '18.04.2',
1295312904
},
12954-
[PROFILE_ID]: {
12955-
brief: 'The id of the sentry profile.',
12956-
type: 'string',
12957-
pii: {
12958-
isPii: 'false',
12959-
},
12960-
isInOtel: false,
12961-
example: '123e4567e89b12d3a456426614174000',
12962-
deprecation: {
12963-
replacement: 'sentry.profile_id',
12964-
},
12965-
aliases: [SENTRY_PROFILE_ID],
12966-
},
1296712905
[QUERY_KEY]: {
1296812906
brief: 'An item in a query string. Usually added by client-side routing frameworks like vue-router.',
1296912907
type: 'string',
@@ -13422,16 +13360,6 @@ export const ATTRIBUTE_METADATA: Record<AttributeName, AttributeMetadata> = {
1342213360
isInOtel: false,
1342313361
example: '18779b64dd35d1a538e7ce2dd2d3fad3',
1342413362
},
13425-
[SENTRY_PROFILE_ID]: {
13426-
brief: 'The id of the sentry profile.',
13427-
type: 'string',
13428-
pii: {
13429-
isPii: 'false',
13430-
},
13431-
isInOtel: false,
13432-
example: '123e4567e89b12d3a456426614174000',
13433-
aliases: [PROFILE_ID],
13434-
},
1343513363
[SENTRY_RELEASE]: {
1343613364
brief: 'The sentry release.',
1343713365
type: 'string',
@@ -14532,7 +14460,6 @@ export type Attributes = {
1453214460
[PROCESS_RUNTIME_DESCRIPTION]?: PROCESS_RUNTIME_DESCRIPTION_TYPE;
1453314461
[PROCESS_RUNTIME_NAME]?: PROCESS_RUNTIME_NAME_TYPE;
1453414462
[PROCESS_RUNTIME_VERSION]?: PROCESS_RUNTIME_VERSION_TYPE;
14535-
[PROFILE_ID]?: PROFILE_ID_TYPE;
1453614463
[QUERY_KEY]?: QUERY_KEY_TYPE;
1453714464
[RELEASE]?: RELEASE_TYPE;
1453814465
[REMIX_ACTION_FORM_DATA_KEY]?: REMIX_ACTION_FORM_DATA_KEY_TYPE;
@@ -14579,7 +14506,6 @@ export type Attributes = {
1457914506
[SENTRY_ORIGIN]?: SENTRY_ORIGIN_TYPE;
1458014507
[SENTRY_PLATFORM]?: SENTRY_PLATFORM_TYPE;
1458114508
[SENTRY_PROFILER_ID]?: SENTRY_PROFILER_ID_TYPE;
14582-
[SENTRY_PROFILE_ID]?: SENTRY_PROFILE_ID_TYPE;
1458314509
[SENTRY_RELEASE]?: SENTRY_RELEASE_TYPE;
1458414510
[SENTRY_REPLAY_ID]?: SENTRY_REPLAY_ID_TYPE;
1458514511
[SENTRY_REPLAY_IS_BUFFERING]?: SENTRY_REPLAY_IS_BUFFERING_TYPE;

model/attributes/profile_id.json

Lines changed: 0 additions & 15 deletions
This file was deleted.

model/attributes/sentry/sentry__profile_id.json

Lines changed: 0 additions & 11 deletions
This file was deleted.

python/src/sentry_conventions/attributes.py

Lines changed: 0 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,6 @@ class _AttributeNamesMeta(type):
152152
"NET_SOCK_PEER_NAME",
153153
"NET_SOCK_PEER_PORT",
154154
"NET_TRANSPORT",
155-
"PROFILE_ID",
156155
"QUERY_KEY",
157156
"RELEASE",
158157
"REPLAY_ID",
@@ -3487,18 +3486,6 @@ class ATTRIBUTE_NAMES(metaclass=_AttributeNamesMeta):
34873486
Example: "18.04.2"
34883487
"""
34893488

3490-
# Path: model/attributes/profile_id.json
3491-
PROFILE_ID: Literal["profile_id"] = "profile_id"
3492-
"""The id of the sentry profile.
3493-
3494-
Type: str
3495-
Contains PII: false
3496-
Defined in OTEL: No
3497-
Aliases: sentry.profile_id
3498-
DEPRECATED: Use sentry.profile_id instead
3499-
Example: "123e4567e89b12d3a456426614174000"
3500-
"""
3501-
35023489
# Path: model/attributes/query/query__[key].json
35033490
QUERY_KEY: Literal["query.<key>"] = "query.<key>"
35043491
"""An item in a query string. Usually added by client-side routing frameworks like vue-router.
@@ -3993,17 +3980,6 @@ class ATTRIBUTE_NAMES(metaclass=_AttributeNamesMeta):
39933980
Example: "php"
39943981
"""
39953982

3996-
# Path: model/attributes/sentry/sentry__profile_id.json
3997-
SENTRY_PROFILE_ID: Literal["sentry.profile_id"] = "sentry.profile_id"
3998-
"""The id of the sentry profile.
3999-
4000-
Type: str
4001-
Contains PII: false
4002-
Defined in OTEL: No
4003-
Aliases: profile_id
4004-
Example: "123e4567e89b12d3a456426614174000"
4005-
"""
4006-
40073983
# Path: model/attributes/sentry/sentry__profiler_id.json
40083984
SENTRY_PROFILER_ID: Literal["sentry.profiler_id"] = "sentry.profiler_id"
40093985
"""The id of the currently running profiler (continuous profiling)
@@ -7264,15 +7240,6 @@ class ATTRIBUTE_NAMES(metaclass=_AttributeNamesMeta):
72647240
is_in_otel=True,
72657241
example="18.04.2",
72667242
),
7267-
"profile_id": AttributeMetadata(
7268-
brief="The id of the sentry profile.",
7269-
type=AttributeType.STRING,
7270-
pii=PiiInfo(isPii=IsPii.FALSE),
7271-
is_in_otel=False,
7272-
example="123e4567e89b12d3a456426614174000",
7273-
deprecation=DeprecationInfo(replacement="sentry.profile_id"),
7274-
aliases=["sentry.profile_id"],
7275-
),
72767243
"query.<key>": AttributeMetadata(
72777244
brief="An item in a query string. Usually added by client-side routing frameworks like vue-router.",
72787245
type=AttributeType.STRING,
@@ -7612,14 +7579,6 @@ class ATTRIBUTE_NAMES(metaclass=_AttributeNamesMeta):
76127579
is_in_otel=False,
76137580
example="php",
76147581
),
7615-
"sentry.profile_id": AttributeMetadata(
7616-
brief="The id of the sentry profile.",
7617-
type=AttributeType.STRING,
7618-
pii=PiiInfo(isPii=IsPii.FALSE),
7619-
is_in_otel=False,
7620-
example="123e4567e89b12d3a456426614174000",
7621-
aliases=["profile_id"],
7622-
),
76237582
"sentry.profiler_id": AttributeMetadata(
76247583
brief="The id of the currently running profiler (continuous profiling)",
76257584
type=AttributeType.STRING,
@@ -8553,7 +8512,6 @@ class ATTRIBUTE_NAMES(metaclass=_AttributeNamesMeta):
85538512
"process.runtime.description": str,
85548513
"process.runtime.name": str,
85558514
"process.runtime.version": str,
8556-
"profile_id": str,
85578515
"query.<key>": str,
85588516
"release": str,
85598517
"remix.action_form_data.<key>": str,
@@ -8599,7 +8557,6 @@ class ATTRIBUTE_NAMES(metaclass=_AttributeNamesMeta):
85998557
"sentry.op": str,
86008558
"sentry.origin": str,
86018559
"sentry.platform": str,
8602-
"sentry.profile_id": str,
86038560
"sentry.profiler_id": str,
86048561
"sentry.release": str,
86058562
"sentry.replay_id": str,

shared/deprecated_attributes.json

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -48,21 +48,6 @@
4848
"alias": ["http.request.method"],
4949
"sdks": ["javascript-browser", "javascript-node"]
5050
},
51-
{
52-
"key": "profile_id",
53-
"brief": "The id of the sentry profile.",
54-
"type": "string",
55-
"pii": {
56-
"key": "false"
57-
},
58-
"is_in_otel": false,
59-
"example": "123e4567e89b12d3a456426614174000",
60-
"deprecation": {
61-
"_status": null,
62-
"replacement": "sentry.profile_id"
63-
},
64-
"alias": ["sentry.profile_id"]
65-
},
6651
{
6752
"key": "release",
6853
"brief": "The sentry release.",

0 commit comments

Comments
 (0)