Skip to content

Commit b24cd9c

Browse files
authored
Remove SentryTimingsCallback and use Flutter's TimingsCallback instead (#3054)
* Update * Update CHANGELOG * Update CHANGELOG.md
1 parent fd4d716 commit b24cd9c

File tree

2 files changed

+8
-7
lines changed

2 files changed

+8
-7
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,10 @@
66

77
- `ScreenshotIntegration` not being added for web ([#3055](https://github.com/getsentry/sentry-dart/pull/3055))
88

9+
### Enhancements
10+
11+
- Remove `SentryTimingsCallback` and use Flutter's `TimingsCallback` instead ([#3054](https://github.com/getsentry/sentry-dart/pull/3054))
12+
913
## 9.4.0
1014

1115
### Fixes

flutter/lib/src/frame_callback_handler.dart

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,10 @@
11
import 'package:flutter/cupertino.dart';
22
import 'package:flutter/scheduler.dart';
33

4-
/// Use instead of TimingsCallback as it is not available in the Flutter min version
5-
typedef SentryTimingsCallback = void Function(List<FrameTiming> timings);
6-
74
abstract class FrameCallbackHandler {
85
void addPostFrameCallback(FrameCallback callback);
9-
void removeTimingsCallback(SentryTimingsCallback callback);
10-
void addTimingsCallback(SentryTimingsCallback callback);
6+
void removeTimingsCallback(TimingsCallback callback);
7+
void addTimingsCallback(TimingsCallback callback);
118
}
129

1310
class DefaultFrameCallbackHandler implements FrameCallbackHandler {
@@ -20,14 +17,14 @@ class DefaultFrameCallbackHandler implements FrameCallbackHandler {
2017
}
2118

2219
@override
23-
void addTimingsCallback(SentryTimingsCallback callback) {
20+
void addTimingsCallback(TimingsCallback callback) {
2421
try {
2522
WidgetsBinding.instance.addTimingsCallback(callback);
2623
} catch (_) {}
2724
}
2825

2926
@override
30-
void removeTimingsCallback(SentryTimingsCallback callback) {
27+
void removeTimingsCallback(TimingsCallback callback) {
3128
try {
3229
WidgetsBinding.instance.removeTimingsCallback(callback);
3330
} catch (_) {}

0 commit comments

Comments
 (0)