enh: remove async from FlutterErrorIntegration (#3202)

* Remove async from flutter error integration

* Update

* Update CHANGELOG

Author: buenaflor

CHANGELOG.md

@@ -19,6 +19,7 @@
 - Use FFI/JNI for `captureEnvelope` on iOS and Android ([#3115](https://github.com/getsentry/sentry-dart/pull/3115))
 - Log a warning when dropping envelope items ([#3165](https://github.com/getsentry/sentry-dart/pull/3165))
 - Call options.log for structured logs ([#3187](https://github.com/getsentry/sentry-dart/pull/3187))
+- Remove async usage from `FlutterErrorIntegration` ([#3202](https://github.com/getsentry/sentry-dart/pull/3202))
 - Tag all spans during app start with start type info ([#3190](https://github.com/getsentry/sentry-dart/pull/3190))
 
 ### Dependencies

packages/flutter/lib/src/integrations/flutter_error_integration.dart

@@ -1,3 +1,5 @@
+import 'dart:async';
+
 import 'package:flutter/foundation.dart';
 import 'package:sentry/sentry.dart';
 import '../sentry_flutter_options.dart';
@@ -22,7 +24,7 @@ class FlutterErrorIntegration implements Integration<SentryFlutterOptions> {
   @override
   void call(Hub hub, SentryFlutterOptions options) {
     _defaultOnError = FlutterError.onError;
-    _integrationOnError = (FlutterErrorDetails errorDetails) async {
+    _integrationOnError = (FlutterErrorDetails errorDetails) {
       final exception = errorDetails.exception;
 
       options.log(
@@ -88,7 +90,7 @@ class FlutterErrorIntegration implements Integration<SentryFlutterOptions> {
           stackTrace = getCurrentStackTrace();
           hint.addAll({TypeCheckHint.currentStackTrace: true});
         }
-        await hub.captureEvent(event, stackTrace: stackTrace, hint: hint);
+        unawaited(hub.captureEvent(event, stackTrace: stackTrace, hint: hint));
         // we don't call Zone.current.handleUncaughtError because we'd like
         // to set a specific mechanism for FlutterError.onError.
       } else {

packages/flutter/lib/src/integrations/on_error_integration.dart

@@ -1,3 +1,5 @@
+import 'dart:async';
+
 import 'package:sentry/sentry.dart';
 // ignore: implementation_imports
 import 'package:sentry/src/utils/stacktrace_utils.dart';
@@ -83,8 +85,7 @@ class OnErrorIntegration implements Integration<SentryFlutterOptions> {
         stackTrace = getCurrentStackTrace();
         hint = Hint.withMap({TypeCheckHint.currentStackTrace: true});
       }
-      // unawaited future
-      hub.captureEvent(event, stackTrace: stackTrace, hint: hint);
+      unawaited(hub.captureEvent(event, stackTrace: stackTrace, hint: hint));
 
       return handled;
     };

packages/flutter/test/integrations/flutter_error_integration_test.dart

@@ -41,8 +41,7 @@ void main() {
       _mockValues();
 
       // replace default error otherwise it fails on testing
-      FlutterError.onError =
-          handler ?? (FlutterErrorDetails errorDetails) async {};
+      FlutterError.onError = handler ?? (FlutterErrorDetails errorDetails) {};
 
       final sut = fixture.getSut();
       sut(fixture.hub, fixture.options);
@@ -169,7 +168,7 @@ void main() {
       _mockValues();
 
       var numberOfDefaultCalls = 0;
-      final defaultError = (FlutterErrorDetails errorDetails) async {
+      final defaultError = (FlutterErrorDetails errorDetails) {
         numberOfDefaultCalls++;
       };
       FlutterError.onError = defaultError;