Skip to content

deps(ffigen): pin ffigen to 19.0.0 #3163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Aug 14, 2025
Merged

deps(ffigen): pin ffigen to 19.0.0 #3163

merged 14 commits into from
Aug 14, 2025

Conversation

buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Aug 12, 2025 •
edited
Loading

📜 Description

Use latest compatible ffigen version

Make sure it doesnt affect functionalities and doesn't crash

💡 Motivation and Context

Tiny step towards #1444

💚 How did you test it?

Manual tests and current test suite

Confirmed the new bindings to be working on iOS, macOS, Linux and Windows through manual tests

📝 Checklist

  • I reviewed submitted code
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@codecov Codecov
Copy link

codecov bot commented Aug 12, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.85%. Comparing base (dad9228) to head (1d6c314).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...tter/lib/src/native/cocoa/sentry_native_cocoa.dart 42.85% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3163      +/-   ##
==========================================
+ Coverage   86.56%   89.85%   +3.29%     
==========================================
  Files         193       96      -97     
  Lines        6364     3431    -2933     
==========================================
- Hits         5509     3083    -2426     
+ Misses        855      348     -507

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@buenaflor buenaflor marked this pull request as ready for review August 13, 2025 08:34
@buenaflor buenaflor changed the title [draft] deps(ffigen): pin ffigen to 19.0.0 deps(ffigen): pin ffigen to 19.0.0 Aug 13, 2025
@buenaflor buenaflor merged commit f32fcc6 into main Aug 14, 2025
62 of 67 checks passed
@buenaflor buenaflor deleted the deps/bump-ffigen branch August 14, 2025 09:06
@github-actions GitHub Actions
Copy link
Contributor

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- pin ffigen to `19.0.0` ([#3163](https://github.com/getsentry/sentry-dart/pull/3163))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description or adding a skip-changelog label.

Generated by 🚫 dangerJS against 1d6c314

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denrase denrase denrase approved these changes

@stefanosiano stefanosiano Awaiting requested review from stefanosiano stefanosiano is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@buenaflor @denrase