Skip to content

Revert FFI usage on iOS/macOS #3379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
buenaflor wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

Revert FFI usage on iOS/macOS #3379

buenaflor wants to merge 13 commits into from

Conversation

@buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Dec 4, 2025

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@buenaflor buenaflor changed the title Revert FFI usage on iOS Revert FFI usage on iOS/macOS Dec 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2025 •
edited
Loading

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

### Features

- Revert FFI usage on iOS/macOS ([#3379](https://github.com/getsentry/sentry-dart/pull/3379))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description or adding a skip-changelog label.

Generated by 🚫 dangerJS against a7204e6

@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2025 •
edited
Loading

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 441.33 ms 465.69 ms 24.36 ms
Size 13.93 MiB 15.18 MiB 1.25 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
73a3c38 478.18 ms 526.62 ms 48.44 ms
40c8f93 417.10 ms 482.60 ms 65.50 ms
8541716 437.14 ms 443.65 ms 6.51 ms
d3fb366 391.49 ms 385.85 ms -5.64 ms
2cf9161 454.12 ms 512.67 ms 58.55 ms
1f639ee 429.98 ms 476.60 ms 46.62 ms
b6c8720 457.41 ms 519.04 ms 61.63 ms
a69a51f 437.18 ms 450.60 ms 13.42 ms
6bcdc99 440.23 ms 435.77 ms -4.46 ms
393f8ec 360.07 ms 362.70 ms 2.64 ms

App size

Revision Plain With Sentry Diff
73a3c38 6.54 MiB 7.69 MiB 1.15 MiB
40c8f93 13.93 MiB 15.00 MiB 1.06 MiB
8541716 13.93 MiB 15.00 MiB 1.06 MiB
d3fb366 13.93 MiB 15.06 MiB 1.13 MiB
2cf9161 6.54 MiB 7.70 MiB 1.16 MiB
1f639ee 13.93 MiB 15.00 MiB 1.06 MiB
b6c8720 6.54 MiB 7.69 MiB 1.15 MiB
a69a51f 13.93 MiB 15.06 MiB 1.13 MiB
6bcdc99 13.93 MiB 15.00 MiB 1.06 MiB
393f8ec 13.93 MiB 15.06 MiB 1.13 MiB

Previous results on branch: revert/ios-ffi

Startup times

Revision Plain With Sentry Diff
ead6989 364.43 ms 394.60 ms 30.16 ms
4e98d39 411.14 ms 428.36 ms 17.21 ms
45f37bc 360.73 ms 355.24 ms -5.48 ms
913a00b 367.70 ms 353.00 ms -14.70 ms
ab2ec2e 363.49 ms 378.42 ms 14.93 ms

App size

Revision Plain With Sentry Diff
ead6989 13.93 MiB 15.18 MiB 1.25 MiB
4e98d39 13.93 MiB 15.18 MiB 1.25 MiB
45f37bc 13.93 MiB 15.18 MiB 1.25 MiB
913a00b 13.93 MiB 15.18 MiB 1.25 MiB
ab2ec2e 13.93 MiB 15.18 MiB 1.25 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2025 •
edited
Loading

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1255.06 ms 1261.69 ms 6.63 ms
Size 5.53 MiB 5.96 MiB 444.50 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
c0dde50 1268.90 ms 1275.61 ms 6.71 ms
1f639ee 1252.43 ms 1257.82 ms 5.38 ms
7cfee3b 1260.90 ms 1273.14 ms 12.24 ms
192b44c 1269.08 ms 1275.52 ms 6.44 ms
7b21e8b 1256.79 ms 1267.12 ms 10.33 ms
6f47800 1247.52 ms 1259.37 ms 11.85 ms
ad121c0 1275.04 ms 1280.59 ms 5.55 ms
e04b24b 1230.22 ms 1233.90 ms 3.67 ms
819c1e7 1250.59 ms 1249.08 ms -1.51 ms
d0aa4b6 1268.23 ms 1268.39 ms 0.15 ms

App size

Revision Plain With Sentry Diff
c0dde50 5.53 MiB 6.01 MiB 488.14 KiB
1f639ee 5.53 MiB 6.00 MiB 479.95 KiB
7cfee3b 20.70 MiB 22.46 MiB 1.75 MiB
192b44c 5.53 MiB 5.96 MiB 444.33 KiB
7b21e8b 5.53 MiB 6.00 MiB 479.96 KiB
6f47800 7.86 MiB 9.44 MiB 1.58 MiB
ad121c0 5.53 MiB 6.01 MiB 488.11 KiB
e04b24b 5.53 MiB 6.00 MiB 480.00 KiB
819c1e7 5.53 MiB 6.00 MiB 479.96 KiB
d0aa4b6 5.53 MiB 6.02 MiB 502.04 KiB

Previous results on branch: revert/ios-ffi

Startup times

Revision Plain With Sentry Diff
913a00b 1268.16 ms 1263.40 ms -4.76 ms
ab2ec2e 1232.69 ms 1248.23 ms 15.55 ms
4e98d39 1253.35 ms 1256.76 ms 3.41 ms
45f37bc 1263.33 ms 1264.35 ms 1.01 ms
ead6989 1275.31 ms 1275.08 ms -0.22 ms

App size

Revision Plain With Sentry Diff
913a00b 5.53 MiB 5.96 MiB 444.49 KiB
ab2ec2e 5.53 MiB 5.96 MiB 444.49 KiB
4e98d39 5.53 MiB 5.96 MiB 444.50 KiB
45f37bc 5.53 MiB 5.96 MiB 444.62 KiB
ead6989 5.53 MiB 5.96 MiB 444.49 KiB

@codecov
Copy link

codecov bot commented Dec 4, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.43%. Comparing base (1302124) to head (a7204e6).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3379      +/-   ##
==========================================
+ Coverage   88.31%   91.43%   +3.11%     
==========================================
  Files         291       95     -196     
  Lines        9957     3198    -6759     
==========================================
- Hits         8794     2924    -5870     
+ Misses       1163      274     -889

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@denrase denrase Awaiting requested review from denrase denrase will be requested when the pull request is marked ready for review denrase is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@buenaflor