Skip to content

Commit 0a6327d

Browse files
committed
add set-cookie
1 parent 40b6461 commit 0a6327d

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

develop-docs/sdk/expected-features/data-handling.mdx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ Before sending events to Sentry, the SDKs should invokes callbacks. That allows
4343

4444
### Cookies
4545

46-
Since cookies can contain a mix of sensitive and non-sensitive data, SDKs should parse the cookie header and filter values on a per-key basis, depending on the SDK setting and the sensitivity of the cookie value.
46+
Since `Cookie` and `Set-Cookie` headers can contain a mix of sensitive and non-sensitive data, SDKs should parse the cookie header and filter values on a per-key basis, depending on the SDK setting and the sensitivity of the cookie value.
4747
In case, the SDK cannot parse each cookie key-value pair, the entire cookie header must be replaced with `"[Filtered]"`. An unfiltered, raw cookie header value must never be sent.
4848

4949
This selective filtering prevents capturing sensitive data while retaining harmless contextual information for debugging.
@@ -53,6 +53,7 @@ When attached as span attributes, the results should be as follows:
5353

5454
- `http.request.header.cookie.user_session: "[Filtered]"`
5555
- `http.request.header.cookie.theme: "dark-mode"`
56+
- `http.request.header.set_cookie.theme: "light-mode"`
5657
- `http.request.header.cookie: "[Filtered]"` (Used as a fallback if the cookie header cannot be parsed)
5758

5859
### Application State

develop-docs/sdk/expected-features/index.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -361,7 +361,7 @@ The HTTP Client integration should have 3 configuration options:
361361
- If the language has a `Range` type, it should be used instead of `HttpStatusCodeRange`.
362362
- `failedRequestTargets` defaults to (`.*`), this configuration option accepts a `List` of `String` that may be Regular expressions as well, similar to <Link to="/sdk/telemetry/traces/#tracepropagationtargets">tracePropagationTargets</Link>.
363363
- The SDK will only capture HTTP Client errors if the HTTP Request URL is a match for any of the `failedRequestsTargets`.
364-
- While the keys of sensitive HTTP headers (e.g. `Cookie` and `Set-Cookie`) are included, their values must be replaced with `"[Filtered]"` (also see <Link to="/sdk/expected-features/data-handling/#sensitive-data">Data Handling: Sensitive Data</Link>).
364+
- While the keys of sensitive HTTP headers (e.g. `Authorization` and `Cookie`) are included, their values must be replaced with `"[Filtered]"` (also see <Link to="/sdk/expected-features/data-handling/#sensitive-data">Data Handling: Sensitive Data</Link>).
365365

366366
The HTTP Client integration should capture error events with the following properties:
367367

0 commit comments

Comments
 (0)