Skip to content

Commit 161c795

Browse files
mtopo27coolguyzone
andauthored
Apply suggestions from code review
Alex suggestions Co-authored-by: Alex Krawiec <[email protected]>
1 parent b91ef9b commit 161c795

File tree

3 files changed

+8
-6
lines changed

3 files changed

+8
-6
lines changed

docs/platforms/android/size-analysis/insights.mdx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,9 @@ Below are a list of available insights for Android builds, followed by more deta
3535

3636
**Options**:
3737

38-
- Use Android Studio: right-click an image → **Convert to WebP** → choose **Lossless**.
38+
**Options:**
39+
40+
- Use Android Studio: right-click an image → **Convert to WebP** → select **Lossless**.
3941
- Use the command line:
4042

4143
```bash

docs/platforms/apple/guides/ios/size-analysis/index.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ description: Upload iOS builds to Sentry for size analysis.
1212

1313
**Accepted Formats**: XCArchive (preferred) | IPA
1414

15-
**Upload Mechanisms**: [Fastlane Plugin](#uploading-with-fastlane) | [Sentry CLI](#uploading-with-the-sentry-cli)
15+
**Upload Mechanisms**: [Fastlane Plugin](#uploading-with-fastlane) (version 1.34.0 or higher) *or* [Sentry CLI](#uploading-with-the-sentry-cli)
1616

1717
### Uploading with Fastlane
1818

docs/platforms/apple/guides/ios/size-analysis/insights.mdx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ Below are a list of available insights for iOS builds, followed by more details
4040
has them) before stripping.
4141
</Alert>
4242

43-
In Xcode ensure your release configuration sets the `Debug Information Format` build setting to `DWARF with dSYM`.
43+
In Xcode, ensure your release configuration sets the `Debug Information Format` build setting to `DWARF with dSYM`.
4444

4545
The `strip` command can then remove the extra information:
4646

@@ -192,7 +192,7 @@ optimize_icon() {
192192

193193
### Loose Images
194194

195-
**What it is**: Finds scaled @1x/@2x/@3x images stored outside of asset catalogs. This prevents app thinning from removing variants not needed for the user's device.
195+
**What it is**: Finds scaled @1x/@2x/@3x images stored outside of asset catalogs. App thinning will not remove these images, even when they are not needed for the user's device.
196196

197197
**How to fix**: Move each image set into an asset catalog in Xcode.
198198

@@ -226,11 +226,11 @@ optimize_icon() {
226226

227227
**How to fix**: Start with low-effort cleanup, then automate comment stripping if you still ship large payloads.
228228

229-
#### Option 1: Keep the format lean
229+
#### Option 1: Keep the Format Lean
230230

231231
- Encode localized strings as plain text (`"key" = "value";`), not binary plists. Set **Strings File Output Encoding** (`STRINGS_FILE_OUTPUT_ENCODING`) to **UTF-8** in Xcode.
232232

233-
#### Option 2: Strip comments automatically
233+
#### Option 2: Strip Comments Automatically
234234

235235
String files can have comments that ship with the bundle. They help during translation but take space in production. A typical comment may look like:
236236

0 commit comments

Comments
 (0)