Skip to content

Commit 1e03099

Browse files
committed
review feedback
1 parent f8f9979 commit 1e03099

File tree

6 files changed

+18
-8
lines changed

6 files changed

+18
-8
lines changed
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
We are still working on Logs. Please open [a new GitHub issue](https://github.com/getsentry/sentry-java/issues/new/choose) for any integration you would like to see.
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
We are still working on Logs. You can follow progress on the following GitHub issues or open a new one for any integration you would like to see.
2+
3+
- [Logback](https://github.com/getsentry/sentry-java/issues/4404)
4+
- [Log4j2](https://github.com/getsentry/sentry-java/issues/4403)
5+
- [JUL](https://github.com/getsentry/sentry-java/issues/4405)

platform-includes/logs/options/android.mdx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
To filter logs, or update them before they are sent to Sentry, you can use the `getLogs().beforeSend` option.
44

5-
```java {tabTitle: Java}
5+
```java {tabTitle: Java} {10-14}
66
import io.sentry.SentryLevel;
77
import io.sentry.android.core.SentryAndroid;
88
import android.app.Application;
@@ -32,7 +32,7 @@ class MyApplication : Application() {
3232
override fun onCreate() {
3333
super.onCreate()
3434
SentryAndroid.init(this) { options ->
35-
options.dsn = "___PUBLIC_DSN___",
35+
options.dsn = "___PUBLIC_DSN___"
3636
options.logs.beforeSend = BeforeSendLogCallback { logEvent ->
3737
// Modify the event here:
3838
logEvent.body = "new message body"

platform-includes/logs/options/java.mdx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,11 @@
22

33
To filter logs, or update them before they are sent to Sentry, you can use the `getLogs().beforeSend` option.
44

5-
```java {tabTitle: Java}
5+
```java {tabTitle: Java} {5-9}
66
import io.sentry.Sentry;
77

88
Sentry.init(options -> {
9+
options.setDsn("___PUBLIC_DSN___");
910
options.getLogs().setBeforeSend((logEvent) -> {
1011
// Modify the event here:
1112
logEvent.setBody("new message body");
@@ -14,11 +15,12 @@ Sentry.init(options -> {
1415
});
1516
```
1617

17-
```kotlin {tabTitle: Kotlin}
18+
```kotlin {tabTitle: Kotlin} {6-10}
1819
import io.sentry.Sentry
1920
import io.sentry.SentryOptions.Logs.BeforeSendLogCallback
2021

2122
Sentry.init { options ->
23+
options.dsn = "___PUBLIC_DSN___"
2224
options.logs.beforeSend = BeforeSendLogCallback { logEvent ->
2325
// Modify the event here:
2426
logEvent.body = "new message body"

platform-includes/logs/setup/android.mdx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
To enable logging, you need to initialize the SDK with the `logs.enabled` option set to `true`.
22

3-
```java {tabTitle: Java}
3+
```java {tabTitle: Java} {10}
44
import io.sentry.SentryLevel;
55
import io.sentry.android.core.SentryAndroid;
66
import android.app.Application;
@@ -16,7 +16,7 @@ public class MyApplication extends Application {
1616
}
1717
```
1818

19-
```kotlin {tabTitle: Kotlin}
19+
```kotlin {tabTitle: Kotlin} {11}
2020
import io.sentry.android.core.SentryAndroid
2121
import io.sentry.SentryOptions.BeforeSendCallback
2222
import io.sentry.Hint
Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,19 @@
11
To enable logging, you need to initialize the SDK with the `logs.enabled` option set to `true`.
22

3-
```java {tabTitle: Java}
3+
```java {tabTitle: Java} {5}
44
import io.sentry.Sentry;
55

66
Sentry.init(options -> {
7+
options.setDsn("___PUBLIC_DSN___");
78
options.getLogs().setEnabled(true);
89
});
910
```
1011

11-
```kotlin {tabTitle: Kotlin}
12+
```kotlin {tabTitle: Kotlin} {5}
1213
import io.sentry.Sentry
1314

1415
Sentry.init { options ->
16+
options.dsn = "___PUBLIC_DSN___"
1517
options.logs.enabled = true
1618
}
1719
```

0 commit comments

Comments
 (0)