Skip to content

Commit 3cd322f

Browse files
c298leeryan953
andauthored
Apply suggestions from code review
Co-authored-by: Ryan Albrecht <[email protected]>
1 parent c74bf31 commit 3cd322f

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

docs/product/dev-toolbar/setup.mdx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ And you can include any additional fields from this list:
7878

7979
## Implement Feature Flag Adapter
8080

81-
In order to integrate your Feature Flagging platform with the Dev Toolbar, you will need an adapter that can read flag data from your provider, and also store and retrieve a list of overrides to apply to your local browser session.
81+
In order to integrate your feature flagging platform with the Dev Toolbar, you will need an adapter that can read flag data from your provider, and also store and retrieve a list of overrides to apply to your local browser session.
8282

8383
We plan to [create adapters for OpenFeature and LaunchDarkly](https://github.com/getsentry/sentry-toolbar/issues/150) soon.
8484

@@ -125,7 +125,7 @@ In dev and staging environments, you might want to *unconditionally* include the
125125

126126
In production however, it's strongly recommended to *conditionally* include the Dev Toolbar `<script>` tag so that only members of your Sentry organization can see it. The specific implementation for conditionally including the Dev Toolbar is something you'll need to write based on how your app works and how your dev team is set up.
127127

128-
For example, if your web application requires authentication to access, you could add a conditional where the Dev Toolbar is shown always when deployed to development **and** staging and is shown only if an employee is logged in when deployed to production.
128+
For example, if your web application requires authentication to access, you could add a conditional where the Dev Toolbar is shown always when deployed to development **and** staging, but in production only show the toolbar **if** an employee is logged in.
129129

130130

131131
The code might look like this:
@@ -135,7 +135,7 @@ The code might look like this:
135135
const env = process.env.SENTRY_ENVIRONMENT || 'development';
136136
const isEmployee = user.email.endsWith('@joshys-pizza.com')
137137

138-
const isDev = env === 'development' || env === staging;
138+
const isDev = env === 'development' || env === 'staging';
139139
const isEmployeeInProd = env === 'production' && isEmployee;
140140
if (isDev || isEmployeeInProd) {
141141
SentryToolbar.init({ ... });

0 commit comments

Comments
 (0)