handle global wildcards like **/

Author: Jeffreyhung

.github/workflows/codeowner_assignment.yaml

@@ -28,7 +28,7 @@ jobs:
           PR_NUMBER: ${{ github.event.number }}
           GH_TOKEN: ${{ steps.token.outputs.token }}
         run: |
-          # Ensure CODEOWNERS file exists
+          # locate CODEOWNERS file exists
           if [[ -f .github/CODEOWNERS ]]; then
             codeowner_path=".github/CODEOWNERS"
           elif [[ -f CODEOWNERS ]]; then
@@ -50,16 +50,16 @@ jobs:
           echo "----------------------------------------"
 
           # Parse CODEOWNERS and find commented lines
-          # Add newline to the end of the file if it doesn't have one
+          # Add newline to the end of the file if it doesn't have one, otherwise sed will not read the last line
           sed -i -e '$a\' $codeowner_path
           
           while read -r LINE; do
-            # Skip lines that are not commented
+            # Skip lines that are not commented, GitHub will take care of un-commented lines
             if [[ ! "$LINE" =~ ^# ]]; then continue; fi
 
             # Extract pattern and reviewer from the commented line
             PATTERN=$(echo "$LINE" | sed -E 's/^#\s*([^@]+).*$/\1/' | xargs)
-            # Capture both individual users and team reviewers
+            # Capture both individual users and GitHub teams reviewers that have "/" in the name
             REVIEWERS=$(echo "$LINE" | grep -o "@[a-zA-Z0-9_-]\+\(/[a-zA-Z0-9_-]\+\)\?" | tr '\n' ' ' | xargs)
 
             # Skip if no reviewers found
@@ -72,16 +72,50 @@ jobs:
             
             # Match changed files to the pattern
             for FILE in $CHANGED_FILES; do
-              # Check if the file starts with the pattern (removing leading slash)
-              if [[ "$FILE" == ${REGEX_PATTERN}* ]]; then
-                echo "File $FILE matches pattern $PATTERN"
-                # Assign each reviewer
-                for REVIEWER in $REVIEWERS; do
-                  # Remove @ symbol from reviewer name
-                  REVIEWER_NAME=${REVIEWER#@}
-                  echo "Assigning $REVIEWER_NAME to review changes in $FILE"
-                  gh pr edit $PR_NUMBER --add-reviewer "$REVIEWER_NAME"
-                done
+              # For glob patterns(e.g. "**/"), use a different matching approach
+              if [[ "$PATTERN" == *"*"* ]]; then
+                # Special handling for **/ pattern
+                if [[ "$PATTERN" == "**/"* ]]; then
+                  # Get the filename part after **/
+                  FILENAME=${PATTERN#**/}
+                  # Match either the filename directly or with any path prefix
+                  if [[ "$FILE" == "$FILENAME" ]] || [[ "$FILE" == */"$FILENAME" ]]; then
+                    echo "File $FILE matches glob pattern $PATTERN"
+                    # Assign each reviewer
+                    for REVIEWER in $REVIEWERS; do
+                      # Remove @ symbol from reviewer name
+                      REVIEWER_NAME=${REVIEWER#@}
+                      echo " - Assigning $REVIEWER_NAME to review changes in $FILE"
+                      gh pr edit $PR_NUMBER --add-reviewer "$REVIEWER_NAME"
+                    done
+                  fi
+                else
+                  # Convert other glob patterns to regex for matching
+                  GLOB_PATTERN=$(echo "$PATTERN" | sed -e 's/\./\\./g' -e 's/\*/.*/g' -e 's/\?/./g')
+                  if [[ "$FILE" =~ $GLOB_PATTERN ]]; then
+                    echo "File $FILE matches glob pattern $PATTERN"
+                    # Assign each reviewer
+                    for REVIEWER in $REVIEWERS; do
+                      # Remove @ symbol from reviewer name
+                      REVIEWER_NAME=${REVIEWER#@}
+                      echo " - Assigning $REVIEWER_NAME to review changes in $FILE"
+                      gh pr edit $PR_NUMBER --add-reviewer "$REVIEWER_NAME"
+                    done
+                  fi
+                fi
+              else
+                # Original directory matching logic
+                if [[ "$FILE" == ${REGEX_PATTERN}* ]]; then
+                  echo "File $FILE matches pattern $PATTERN"
+                  # Assign each reviewer
+                  for REVIEWER in $REVIEWERS; do
+                    # Remove @ symbol from reviewer name
+                    REVIEWER_NAME=${REVIEWER#@}
+                    echo " - Assigning $REVIEWER_NAME to review changes in $FILE"
+                    gh pr edit $PR_NUMBER --add-reviewer "$REVIEWER_NAME"
+                  done
+                fi
               fi
             done
           done < $codeowner_path
+