Skip to content

Commit 56eb851

Browse files
Apply suggestions from code review
Co-authored-by: Liza Mock <[email protected]>
1 parent 78af134 commit 56eb851

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

docs/platforms/react-native/tracing/instrumentation/custom-navigation.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ description: "Learn how to use Sentry's Generic Navigation instrumentation."
44
sidebar_order: 70
55
---
66

7-
Sentry's React Native SDK package ships with instrumentation for [React Navigation](/platforms/react-native/tracing/instrumentation/react-navigation/) and [React Native Navigation](/platforms/react-native/tracing/instrumentation/react-native-navigation/) and [Expo Router](/platforms/react-native/tracing/instrumentation/expo-router/). This allows you to see the performance of your navigation transitions and the errors that occur during them.
7+
Sentry's React Native SDK package ships with instrumentation for [React Navigation](/platforms/react-native/tracing/instrumentation/react-navigation/), [React Native Navigation](/platforms/react-native/tracing/instrumentation/react-native-navigation/), and [Expo Router](/platforms/react-native/tracing/instrumentation/expo-router/). This allows you to see the performance of your navigation transitions and the errors that may occur.
88

99
If you use a navigation library that we don't yet support, or have a custom routing solution, you can use `startIdleNavigationSpan` function to implement your own navigation integration. This page will guide you through setting it up and configuring it to your needs.
1010

docs/platforms/react-native/tracing/instrumentation/expo-router.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ This option will enable automatic measuring of the time to initial display for e
6565

6666
### ignoreEmptyBackNavigationTransactions
6767

68-
Does not sample transactions that are from routes that have been seen any more and don't have any spans. This removes a lot of the clutter as most back navigation transactions are now ignored. The default value is `true`.
68+
This ensures that transactions that are from routes that've been seen and don't have any spans, are not being sampled. This removes a lot of clutter, making it so that most back navigation transactions are now ignored. The default value is `true`.
6969

7070
## Notes
7171

docs/platforms/react-native/tracing/instrumentation/react-native-navigation.mdx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,8 @@ This option specifies how long the instrumentation will wait for the route to mo
4747

4848
### enableTabsInstrumentation
4949

50-
Instrumentation will create a transaction on tab change. By default only navigation commands create transactions. The default value is `false`.
50+
This instrumentation will create a transaction on tab change. By default, only navigation commands create transactions. The default value is `false`.
5151

5252
### ignoreEmptyBackNavigationTransactions
5353

54-
Does not sample transactions that are from routes that have been seen any more and don't have any spans. This removes a lot of the clutter as most back navigation transactions are now ignored. The default value is `true`.
54+
This ensures that transactions that are from routes that've been seen and don't have any spans, are not being sampled. This removes a lot of clutter, making it so that most back navigation transactions are now ignored. The default value is `true`.

docs/platforms/react-native/tracing/instrumentation/react-navigation.mdx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,11 +34,11 @@ This option will enable automatic measuring of the time to initial display for e
3434

3535
### ignoreEmptyBackNavigationTransactions
3636

37-
Does not sample transactions that are from routes that have been seen any more and don't have any spans. This removes a lot of the clutter as most back navigation transactions are now ignored. The default value is `true`.
37+
This ensures that transactions that are from routes that've been seen and don't have any spans, are not being sampled. This removes a lot of clutter, making it so that most back navigation transactions are now ignored. The default value is `true`.
3838

3939
## Notes
4040

41-
- This instrumentation supports React Navigation version 5 and above. Starting the SDK version 6 React Navigation 4 is not supported, please upgrade.
41+
- This instrumentation supports React Navigation version 5 and above. Starting with SDK version 6, React Navigation version 4 will no longer be supported. Please upgrade.
4242

4343
- The instrumentation creates a transaction on every route change including `goBack` navigations.
4444

0 commit comments

Comments
 (0)