Skip to content

Commit 5b84ef2

Browse files
mtopo27coolguyzone
andauthored
Apply suggestions from code review
Co-authored-by: Alex Krawiec <[email protected]>
1 parent 579ca3a commit 5b84ef2

File tree

8 files changed

+11
-12
lines changed

8 files changed

+11
-12
lines changed

docs/platforms/android/size-analysis/index.mdx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,11 @@ description: Upload Android builds to Sentry for Size Analysis.
1515

1616
**Upload Mechanisms**: [Gradle](#uploading-with-gradle) | [Sentry CLI](#uploading-with-the-sentry-cli)
1717

18-
### Uploading with Gradle
18+
### Uploading With Gradle
1919

2020
<Include name="size-analysis/upload-gradle" />
2121

22-
### Uploading with the Sentry CLI
22+
### Uploading With the Sentry CLI
2323

2424
<Include name="size-analysis/upload-cli-android" />
2525

@@ -31,7 +31,7 @@ description: Upload Android builds to Sentry for Size Analysis.
3131

3232
<Include name="size-analysis/build-configuration-android" />
3333

34-
## What's next?
34+
## What's Next?
3535

3636
We strongly recommend integrating Size Analysis into your CI pipeline. Follow our guide on [getting set up in CI](/product/size-analysis/integrating-into-ci/).
3737

docs/platforms/android/size-analysis/insights.mdx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ sidebar_order: 5250
44
description: Preview how Size Analysis reports highlight Android build trends.
55
---
66

7-
Size Analysis Insights point out how opportunities to reduce your Android app's size. They spot patterns like duplicate files, oversized media, or unneeded assets, and list exactly what to fix along with the estimated size savings.
7+
Size Analysis Insights point out opportunities to reduce your Android app's size. They spot patterns like duplicate files, oversized media, or unneeded assets, and list exactly what to fix along with the estimated size savings.
88

99
## Android Insights
1010

@@ -31,7 +31,6 @@ Below are a list of available insights for Android builds, followed by more deta
3131

3232
**How to fix**: Compress images with lossless WebP or resize them before bundling.
3333

34-
**Options**:
3534

3635
**Options:**
3736

docs/platforms/apple/guides/ios/size-analysis/index.mdx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ description: Upload iOS builds to Sentry for size analysis.
1414

1515
**Upload Mechanisms**: [Fastlane Plugin](#uploading-with-fastlane) (version 1.34.0 or higher) *or* [Sentry CLI](#uploading-with-the-sentry-cli)
1616

17-
### Uploading with Fastlane
17+
### Uploading With Fastlane
1818

1919
<Include name="size-analysis/upload-fastlane" />
2020

@@ -38,7 +38,7 @@ description: Upload iOS builds to Sentry for size analysis.
3838

3939
<Include name="size-analysis/app-store-connect-file-sizes" />
4040

41-
## What's next?
41+
## What's Next?
4242

4343
We strongly recommend integrating Size Analysis into your CI pipeline. Follow our guide on [getting set up in CI](/product/size-analysis/integrating-into-ci/).
4444

docs/platforms/apple/guides/ios/size-analysis/insights.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ sidebar_order: 5250
44
description: See how Size Analysis surfaces trends for your iOS builds.
55
---
66

7-
Size Analysis Insights point out how opportunities to reduce your iOS app's size. They spot patterns like duplicate files, oversized media, or unneeded assets, and list exactly what to fix along with the estimated size savings.
7+
Size Analysis Insights point out opportunities to reduce your iOS app's size. They spot patterns like duplicate files, oversized media, or unneeded assets, and list exactly what to fix along with the estimated size savings.
88

99
## iOS Insights
1010

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
Features such as automatically comparing the head build against the base build **will only compare builds of the same build configuration**. This is important to consider when setting up Size Analysis in your CI. For example, `Release` and `Debug` builds can be drastically different depending on the compiler and linker settings used during the build process. Trying to compare the two would give unexpected results.
22

3-
Sometimes this is expected though, say if you want to test the impact of converting your project to use Bazel (e.g. `Release` vs `Release-Bazel`). In this case, it's still possible to perform a manual comparison of builds with different build configurations.
3+
Sometimes this is expected though, say you want to test the impact of converting your project to use Bazel (e.g. `Release` vs `Release-Bazel`). In this case, it's still possible to perform a manual comparison of builds with different build configurations.

includes/size-analysis/upload-cli-android.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
1. Install the [sentry-cli](/cli/)
22

3-
2. Authenticate the sentry-cli by [following these steps](https://docs.sentry.io/cli/configuration/#to-authenticate-manually)
3+
2. Authenticate the Sentry CLI by [following these steps](https://docs.sentry.io/cli/configuration/#to-authenticate-manually)
44

55
3. Build your app to create an AAB (preferred) or APK
66

includes/size-analysis/upload-cli-ios.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
1. Install the [sentry-cli](/cli/)
22

3-
2. Authenticate the sentry-cli by [following these steps](https://docs.sentry.io/cli/configuration/#to-authenticate-manually)
3+
2. Authenticate the Sentry CLI by [following these steps](https://docs.sentry.io/cli/configuration/#to-authenticate-manually)
44

55
3. Build your app to create an XCArchive (preferred) or IPA
66

includes/size-analysis/upload-gradle.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ export SENTRY_AUTH_TOKEN=___ORG_AUTH_TOKEN___
4646

4747
The Gradle plugin automatically detects build metadata from your git repository. On GitHub Actions, all metadata is automatically detected. On other CI systems, you may need to manually set some values using the (`vcsInfo`)[https://developer.android.com/reference/tools/gradle-api/8.8/com/android/build/api/dsl/VcsInfo] extension.
4848

49-
Configure overrides in your Gradle build configuration
49+
Configure overrides in your Gradle build configuration:
5050

5151
```kotlin {filename:build.gradle.kts}
5252
sentry {

0 commit comments

Comments
 (0)