Skip to content

Commit 69e1c2f

Browse files
committed
update wording, save preference to localstorage
1 parent b7d9123 commit 69e1c2f

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

src/components/sidebar/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ export async function Sidebar({path, versions}: SidebarProps) {
9595
</div>
9696
{versions && versions.length >= 1 && (
9797
<div className="mb-3">
98-
<VersionSelector versions={versions} />
98+
<VersionSelector versions={versions} sdk={currentPlatform?.name || ''} />
9999
</div>
100100
)}
101101
</div>

src/components/versionSelector/index.tsx

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import {ChevronDownIcon} from '@radix-ui/react-icons';
44
import * as RadixSelect from '@radix-ui/react-select';
55
import {usePathname, useRouter} from 'next/navigation';
66

7-
import {VERSION_INDICATOR} from 'sentry-docs/versioning';
7+
import {getLocalStorageVersionKey, VERSION_INDICATOR} from 'sentry-docs/versioning';
88

99
import styles from './style.module.scss';
1010

@@ -14,7 +14,7 @@ const stripTrailingSlash = (url: string) => {
1414
return url.replace(/\/$/, '');
1515
};
1616

17-
export function VersionSelector({versions}: {versions: string[]}) {
17+
export function VersionSelector({versions, sdk}: {sdk: string; versions: string[]}) {
1818
const availableVersions = ['latest', ...versions];
1919
const router = useRouter();
2020
const pathname = usePathname();
@@ -45,6 +45,7 @@ export function VersionSelector({versions}: {versions: string[]}) {
4545
const handleVersionChange = (newVersion: string) => {
4646
setSelectedVersion(newVersion);
4747
router.push(getVersionedPathname(newVersion));
48+
localStorage.setItem(getLocalStorageVersionKey(sdk), newVersion);
4849
};
4950

5051
return (
@@ -60,7 +61,7 @@ export function VersionSelector({versions}: {versions: string[]}) {
6061
<RadixSelect.Root value={selectedVersion} onValueChange={handleVersionChange}>
6162
<RadixSelect.Trigger aria-label="Version" className={styles.select}>
6263
<RadixSelect.Value placeholder="Version">
63-
Version: {selectedVersion}
64+
<span className="text-sm">SDK version: {selectedVersion}</span>
6465
</RadixSelect.Value>
6566
<RadixSelect.Icon>
6667
<ChevronDownIcon />

src/versioning.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,2 @@
11
export const VERSION_INDICATOR = '__v';
2+
export const getLocalStorageVersionKey = (platform: string) => `version:${platform}`;

0 commit comments

Comments
 (0)