Skip to content

Commit 8e59c7c

Browse files
Apply suggestions from code review
Co-authored-by: Liza Mock <[email protected]>
1 parent 124950a commit 8e59c7c

File tree

3 files changed

+10
-10
lines changed

3 files changed

+10
-10
lines changed

docs/platforms/react-native/integrations/plugin.mdx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ description: "Learn more about pluggable integrations: HttpClient and RewriteFra
55

66
The Sentry SDK uses integrations to hook into the functionality of popular libraries to automatically instrument your application and give you the best data out of the box.
77

8-
Integrations automatically add error instrumentation, performance instrumentation, and/or extra context information to your application. Some are enabled by default, but you can disable them or modify their settings. Other can be added to extend the default functionality of the SDK.
8+
Integrations automatically add error instrumentation, performance instrumentation, and/or extra context information to your application. Some are enabled by default, but you can disable them or modify their settings. Others can be added to extend the default functionality of the SDK.
99

1010
## Adding an Integration
1111

@@ -92,7 +92,7 @@ Sentry.init({
9292

9393
#### Usage Examples
9494

95-
For example, if the full path to your file is `bundles/bundle1.js`:
95+
We'll use `bundles/bundle1.js` as an example full path to your file for the table below:
9696

9797
| Usage | Path in Stack Trace | Description |
9898
| -------------------------------------- | ------------------- | -------------------------------------------------------------------------------------------------------------------------------- |

docs/platforms/react-native/tracing/instrumentation/automatic-instrumentation.mdx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ We currently provide three routing instrumentations out of the box to instrument
3434

3535
### Additional Instrumentation
3636

37-
- [Custom Navigation](/platforms/react-native/tracing/instrumentation/custom-navigation/) to add custom navigation library integration
37+
- [Custom Navigation](/platforms/react-native/tracing/instrumentation/custom-navigation/) to add the custom navigation library integration
3838
- [Custom Instrumentation](/platforms/react-native/tracing/instrumentation/custom-navigation/) to add custom performance data to your application
3939

4040
## Features
@@ -112,11 +112,11 @@ Sentry.init({
112112

113113
### tracePropagationTargets
114114

115-
The default value of `tracePropagationTargets` is `['localhost', /^\//]`. The React Native SDK will attach the `sentry-trace` header to all outgoing XHR/fetch requests whose destination contains a string in the list or matches a regex in the list. If your frontend is making requests to a different domain, you will need to add the domain there to propagate the `sentry-trace` header to the backend services, which is required to link transactions together as part of a single trace. **The `tracePropagationTargets` option matches against the entire request URL, not just the domain. Using stricter regex to match certain parts of the URL ensures that requests do not unnecessarily have the `sentry-trace` header attached.**
115+
The default value of `tracePropagationTargets` is `['localhost', /^\//]`. The React Native SDK will attach the `sentry-trace` header to all outgoing XHR/fetch requests whose destination contains a string in the list or matches a regex in the list. If your frontend is making requests to a different domain, you'll need to add the domain there to propagate the `sentry-trace` header to the backend services, which is required to link transactions together as part of a single trace. **The `tracePropagationTargets` option matches against the entire request URL, not just the domain. Using stricter regex to match certain parts of the URL ensures that requests don't unnecessarily have the `sentry-trace` header attached.**
116116

117117
<PlatformContent includePath="performance/tracePropagationTargets-example" />
118118

119-
You will need to configure your web server CORS to allow the `sentry-trace` header. The configuration might look like `"Access-Control-Allow-Headers: sentry-trace"`, but the configuration depends on your setup. If you do not allow the `sentry-trace` header, the request might be blocked.
119+
You'll need to configure your web server CORS to allow the `sentry-trace` header. The configuration might look like `"Access-Control-Allow-Headers: sentry-trace"`, but the configuration depends on your setup. If you don't allow the `sentry-trace` header, the request might get blocked.
120120

121121
### beforeStartSpan
122122

@@ -163,13 +163,13 @@ Sentry.init({
163163

164164
### idleTimeoutMs
165165

166-
The idle time, measured in ms, to wait until the transaction will be finished, if there are no unfinished spans. The transaction will use the end timestamp of the last finished span as the endtime for the transaction.
166+
The amount of idle time, measured in ms, you have to wait for the transaction to finish if there are no unfinished spans. The transaction will use the end timestamp of the last finished span as the endtime for the transaction.
167167

168168
The default is `1_000`.
169169

170170
### finalTimeoutMs
171171

172-
The maximum duration of the transaction, measured in ms. If the transaction duration hits the `finalTimeout` value, it will be finished.
172+
The maximum duration of the transaction, measured in ms. If the transaction duration hits the `finalTimeout` value, it will be done.
173173

174174
The default is `60_0000`.
175175

docs/platforms/react-native/tracing/instrumentation/custom-instrumentation.mdx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,9 @@ import * as Sentry from "@sentry/react-native";
2020

2121
There are three key functions for creating spans:
2222

23-
- [startSpan](#starting-an-active-span-startspan): Creates a new span that is active, and which is automatically ended. You'll likely want to use this function.
24-
- [startSpanManual](#starting-an-active-span-with-manual-end-startspanmanual): Creates a new span that is active, which has to be ended manually.
25-
- [startInactiveSpan](#starting-inactive-spans-startinactivespan): Creates a new span that is inactive, which has to be ended manually.
23+
- [startSpan](#starting-an-active-span-startspan): Creates a new span that is active and ends automatically. You'll likely want to use this function.
24+
- [startSpanManual](#starting-an-active-span-with-manual-end-startspanmanual): Creates a new span that is active and has to be ended manually.
25+
- [startInactiveSpan](#starting-inactive-spans-startinactivespan): Creates a new span that is inactive and has to be ended manually.
2626

2727
## Active vs. Inactive Spans
2828

0 commit comments

Comments
 (0)