Skip to content

Commit 96288a5

Browse files
committed
implement feedback
1 parent 8c66851 commit 96288a5

File tree

8 files changed

+13
-55
lines changed

8 files changed

+13
-55
lines changed
Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,7 @@
1-
```dart
2-
import 'package:flutter/widgets.dart';
3-
import 'package:sentry_flutter/sentry_flutter.dart';
4-
5-
Future<void> main() async {
6-
await SentryFlutter.init(
1+
```dart {3}
2+
await SentryFlutter.init(
73
(options) {
8-
options.dsn = '___PUBLIC_DSN___';
94
options.allowUrls = ["^https://sentry.com.*\$", "my-custom-domain"];
105
},
11-
appRunner: initApp, // Init your App.
126
);
13-
}
147
```
Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,7 @@
11
```dart
2-
import 'package:flutter/widgets.dart';
3-
import 'package:sentry_flutter/sentry_flutter.dart';
4-
52
FutureOr<SentryEvent?> beforeSend(SentryEvent event, Hint hint) async {
63
return hint is MyHint ? null : event;
74
}
85
9-
Future<void> main() async {
10-
await SentryFlutter.init((options) => options.beforeSend = beforeSend);
11-
}
6+
await SentryFlutter.init((options) => options.beforeSend = beforeSend);
127
```
Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,9 @@
11
```dart
2-
import 'package:flutter/widgets.dart';
3-
import 'package:sentry_flutter/sentry_flutter.dart';
4-
52
FutureOr<SentryEvent?> beforeSend(SentryEvent event, Hint hint) async {
63
// Modify the event here:
74
event = event.copyWith(serverName: null); // Don't send server names.
85
return event;
96
}
107
11-
Future<void> main() async {
12-
await SentryFlutter.init((options) => options.beforeSend = beforeSend);
13-
}
8+
await SentryFlutter.init((options) => options.beforeSend = beforeSend);
149
```
Lines changed: 6 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,7 @@
1-
```dart
2-
import 'package:flutter/widgets.dart';
3-
import 'package:sentry_flutter/sentry_flutter.dart';
4-
5-
Future<void> main() async {
6-
await SentryFlutter.init(
7-
(options) {
8-
options.dsn = '___PUBLIC_DSN___';
9-
options.denyUrls = ["^.*ends-with-this\$", "denied-url"];
10-
},
11-
appRunner: initApp, // Init your App.
12-
);
13-
}
1+
```dart {3}
2+
await SentryFlutter.init(
3+
(options) {
4+
options.denyUrls = ["^.*ends-with-this\$", "denied-url"];
5+
},
6+
);
147
```
Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,10 @@
11
```dart
2-
import 'package:flutter/widgets.dart';
3-
import 'package:sentry_flutter/sentry_flutter.dart';
4-
52
FutureOr<SentryEvent?> beforeSend(SentryEvent event, Hint hint) async {
63
if (event.throwable is DatabaseException) {
74
event = event.copyWith(fingerprint: ['database-connection-error']);
85
}
96
return event;
107
}
118
12-
Future<void> main() async {
13-
await SentryFlutter.init((options) => options.beforeSend = beforeSend);
14-
}
9+
await SentryFlutter.init((options) => options.beforeSend = beforeSend);
1510
```
Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,10 @@
11
```dart
2-
import 'package:flutter/widgets.dart';
3-
import 'package:sentry_flutter/sentry_flutter.dart';
4-
52
FutureOr<SentryEvent?> beforeSend(SentryEvent event, Hint hint) async {
63
if (event.throwable is DatabaseException) {
74
event = event.copyWith(fingerprint: ['database-connection-error']);
85
}
96
return event;
107
}
118
12-
Future<void> main() async {
13-
await SentryFlutter.init((options) => options.beforeSend = beforeSend);
14-
}
9+
await SentryFlutter.init((options) => options.beforeSend = beforeSend);
1510
```

platform-includes/set-fingerprint/rpc/flutter.mdx

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,4 @@
11
```dart
2-
import 'package:flutter/widgets.dart';
3-
import 'package:sentry_flutter/sentry_flutter.dart';
4-
52
class MyRpcException implements Exception {
63
final String function;
74
final int httpStatusCode;
@@ -21,7 +18,5 @@ FutureOr<SentryEvent?> beforeSend(SentryEvent event, Hint hint) async {
2118
return event;
2219
}
2320
24-
Future<void> main() async {
25-
await SentryFlutter.init((options) => options.beforeSend = beforeSend);
26-
}
21+
await SentryFlutter.init((options) => options.beforeSend = beforeSend);
2722
```

platform-includes/user-feedback/sdk-api-example/flutter.mdx

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,4 @@
11
```dart
2-
import 'package:flutter/widgets.dart';
3-
import 'package:sentry_flutter/sentry_flutter.dart';
4-
52
// Option 1: Retrieving SentryId from beforeSend
63
SentryId sentryId = SentryId.empty();
74

0 commit comments

Comments
 (0)