Skip to content

Commit aebc618

Browse files
stefanosianocoolguyzonealiu39
authored
Apply suggestions from code review
Co-authored-by: Alex Krawiec <[email protected]> Co-authored-by: Andrew Liu <[email protected]>
1 parent ee6ab8f commit aebc618

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

develop-docs/sdk/telemetry/feedbacks.mdx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -131,10 +131,10 @@ The scope is applied to the feedbacks, including tags, attachments, and trace co
131131

132132
[Rate limiting](/sdk/expected-features/rate-limiting/) is applied to feedbacks in the same way as it is applied to events.
133133

134-
### Dropped feedback reports
134+
### Dropped Feedback Reports
135135

136-
There is no sample rate for feedbacks, as they are always sampled. However, a feedback can be discarded at any of the pipeline stages. The SDK should report dropped feedbacks through [client reports](/sdk/telemetry/client-reports/).
136+
There is no sample rate for feedbacks, as they are always sampled. However, a feedback can be discarded at any of the pipeline stages, for reasons like rate limiting or an invalid message (too large or empty). The SDK should report dropped feedbacks through [client reports](/sdk/telemetry/client-reports/).
137137

138138
### Session Replay Integration
139139

140-
SDKs are expected to flush the current Session Replay, if running. This ensures a meaningful replay recording exists and can be included in the `replay_id` attribute of the feedback context.
140+
When sending feedback, SDKs are expected to flush the current Session Replay, if running. This ensures a meaningful replay recording exists and can be included in the `replay_id` attribute of the feedback context.

0 commit comments

Comments
 (0)