Skip to content

Commit d57af68

Browse files
authored
fix(codeowners): don't support GitLab syntax (#15089)
We mention that we support GitLab syntax, even though we don't really support it, and there's substantial differences between GitHub and GitLab syntax. Explicitly mention that we support GitHub syntax, and don't support special GitLab things like sections. See getsentry/sentry#86351 for an example Resolves #9565 ## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs to go live. - [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE --> - [ ] Other deadline: <!-- ENTER DATE HERE --> - [x] None: Not urgent, can wait up to 1 week+ ## PRE-MERGE CHECKLIST *Make sure you've checked the following before merging your changes:* - [ ] Checked Vercel preview for correctness, including links - [ ] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [ ] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs)
1 parent 1cd0abf commit d57af68

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

docs/product/issues/ownership-rules/index.mdx

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -68,13 +68,9 @@ Now that we have code mappings, we are able to transform the paths in your CODEO
6868

6969
You can import and incrementally add the mappings between your "source control teams/users" and "Sentry Teams/users", using [external team/user mappings](/product/issues/ownership-rules/#external-teamuser-mappings). Sentry uses the "external team/user mappings" to convert the owners in your CODEOWNERS file into their equivalents in Sentry. Sentry will automatically ignore rules that are missing team/user mappings.
7070

71-
This feature supports GitHub and GitLab CODEOWNERS file syntax with the following exceptions:
71+
We support GitHub CODEOWNERS file syntax, with one exception: we do not support exclusions (lines without owners). You can find more details about the syntax [in GitHub's documentation](https://docs.github.com/en/github/creating-cloning-and-archiving-repositories/creating-a-repository-on-github/about-code-owners), including [details on unsupported syntax](https://docs.github.com/en/github/creating-cloning-and-archiving-repositories/creating-a-repository-on-github/about-code-owners#syntax-exceptions).
7272

73-
- Escaping a pattern starting with `#` using `\` so it is treated as a pattern and not a comment
74-
- Using `!` to negate a pattern
75-
- Using `[ ]` to define a character range
76-
- [GitLab CODEOWNERS syntax](https://docs.gitlab.com/user/project/codeowners/reference/)
77-
- [GitHub CODEOWNERS syntax exceptions](https://docs.github.com/en/github/creating-cloning-and-archiving-repositories/creating-a-repository-on-github/about-code-owners#syntax-exceptions)
73+
Note that we also do not support [GitLab CODEOWNERS syntax](https://docs.gitlab.com/user/project/codeowners/reference) that isn't also supported by GitHub. For example, we do not support sections, `!` negations, etc.
7874

7975
<Alert>
8076

0 commit comments

Comments
 (0)