Skip to content

Commit eac5c3b

Browse files
authored
RN: Fix Configure Automatic Source Maps Upload script for RN 0.81.1 (#15140)
<!-- Use this checklist to make sure your PR is ready for merge. You may delete any sections you don't need. --> ## DESCRIBE YOUR PR *Tell us what you're changing and why. If your PR **resolves an issue**, please link it so it closes automatically.* This is an iteration over #14839 fixing the [upload iOS script for RN 0.81.1+](https://docs.sentry.io/platforms/react-native/manual-setup/manual-setup/). It also sets the newer version as default. ## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs to go live. - [x] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE --> - [ ] Other deadline: <!-- ENTER DATE HERE --> - [ ] None: Not urgent, can wait up to 1 week+ ## SLA - Teamwork makes the dream work, so please add a reviewer to your PRs. - Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it. Thanks in advance for your help! ## PRE-MERGE CHECKLIST *Make sure you've checked the following before merging your changes:* - [ ] Checked Vercel preview for correctness, including links - [ ] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [ ] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs) ## LEGAL BOILERPLATE <!-- Sentry employees and contractors can delete or ignore this section. --> Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms. ## EXTRA RESOURCES - [Sentry Docs contributor guide](https://docs.sentry.io/contributing/)
1 parent 3ff6cea commit eac5c3b

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

docs/platforms/react-native/manual-setup/manual-setup.mdx

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,15 +62,16 @@ set -e
6262
WITH_ENVIRONMENT="../node_modules/react-native/scripts/xcode/with-environment.sh"
6363
REACT_NATIVE_XCODE="../node_modules/react-native/scripts/react-native-xcode.sh"
6464
SENTRY_XCODE="../node_modules/@sentry/react-native/scripts/sentry-xcode.sh"
65-
BUNDLE_REACT_NATIVE="/bin/sh $SENTRY_XCODE $REACT_NATIVE_XCODE"
6665

6766
# RN 0.81.1+
68-
# /bin/sh -c "$WITH_ENVIRONMENT $BUNDLE_REACT_NATIVE"
67+
/bin/sh -c "$WITH_ENVIRONMENT /bin/sh $SENTRY_XCODE $REACT_NATIVE_XCODE"
6968

7069
# RN 0.69 - 0.80.0
71-
/bin/sh -c "$WITH_ENVIRONMENT \"$BUNDLE_REACT_NATIVE\""
70+
# BUNDLE_REACT_NATIVE="/bin/sh $SENTRY_XCODE $REACT_NATIVE_XCODE"
71+
# /bin/sh -c "$WITH_ENVIRONMENT \"$BUNDLE_REACT_NATIVE\""
7272

7373
# RN 0.46 – 0.68
74+
# BUNDLE_REACT_NATIVE="/bin/sh $SENTRY_XCODE $REACT_NATIVE_XCODE"
7475
# /bin/sh -c "$BUNDLE_REACT_NATIVE"
7576
```
7677

0 commit comments

Comments
 (0)