Skip to content

Commit fdd6644

Browse files
docs(sdk): Clarify HTTP response codes considered successful (#13256)
* chore(sdk): Clarify HTTP response codes considered successful * Apply suggestions from code review Co-authored-by: Alex Krawiec <[email protected]> --------- Co-authored-by: Alex Krawiec <[email protected]>
1 parent 3ddd8d0 commit fdd6644

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

develop-docs/sdk/expected-features/index.mdx

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -232,16 +232,17 @@ This feature is also known as 'Offline Caching'.
232232

233233
Write events to disk before attempting to send, so that they can be retried in the event of a temporary network failure. Needs to implement a cap on the number of stored events. This is mostly useful on mobile and desktop(e.g: laptop) apps, where stable connectivity is often not available.
234234

235-
#### Dealing with failures
235+
### Dealing With Network Failures
236236

237-
It's important to note that retry is only considered in the event of a network failure. For example:
237+
An `HTTP 2xx` status code response from Sentry is considered a successful send. It's important to note that retry is only considered in the event of a network failure. For example:
238238

239239
* Connection timeout
240240
* DSN resolution failure
241241
* Connection reset by peer
242242

243243
Other failures, like those caused by processing the file in the SDK itself, the payload should be discarded since those are likely to end up on an endless retry.
244-
If the event reached Sentry and a HTTP response status code was received, even in the event of a `500` response, the event should be discarded.
244+
If the event reached Sentry and an HTTP response status code was received, even in the event of an `HTTP 500` status code, the event should be discarded.
245+
245246

246247
#### Additional capabilities
247248

0 commit comments

Comments
 (0)