Docs is showing preview package versions for install

[bruno-garcia]

Steps to Reproduce

We made a preview release of the .NET SDK: getsentry/sentry-release-registry@f2d6a8c

Now the docs is suggesting that to be installed:

Note, this was the default behavior of the docs since ~2019 when we introduced release registry to the docs. Because customers can experience challenges on their first attempt to use Sentry so that's not ideal

Also note that a new version was shipped 13 hours ago, but docs still shows the preview (and older) version:

Expected Result

Docs excludes preview versions. For example, if version includes -, skip it.

Actual Result

preview version showed up

Additional Info

No response

[bruno-garcia]

There's actually a new version published yesterday: getsentry/sentry-release-registry@322d710

https://github.com/getsentry/sentry-release-registry/blob/bfb30041f42e6f439de04c31889dd1a660345a63/packages/nuget/Sentry.AspNetCore.Blazor.WebAssembly/4.13.0.json

And it's still showing the preview version:

[chargome]

@bruno-garcia 14.12.1-dump.json is listed as latest in the release registry: https://github.com/getsentry/sentry-release-registry/blob/master/packages/nuget/Sentry.AspNetCore.Blazor.WebAssembly/latest.json

So I don't think this is a docs issue, but @Lms24 will help me take a look at the according logic in the release registry repo.

[Lms24]

@bruno-garcia did we bump from 4.x to 14.x on purpose?

The reason this version is shown here instead of 4.13.0 is because the craft release registry target compares what is currently in latest.json, which is 14.12.1-dump1 against the version to be released. In this case, that was 4.13.0. Our comparison logic compares the major versions and immediately returns because 14 > 4. Meaning, we didn't update the latest.json symlink in the registry, causing the release registry API to return 14.12.1-dump1 as the latest version.

In case this was a mistake, I think we need to manually clean up the release registry which should fix the issue. Let me know if you want to do it, otherwise I can also take a look.

By the way, this applies not just to Sentry.AspBetCore.Blazor.WebAssembly but to all Sentry.AspNetCore.* packages

[bruno-garcia]

In case this was a mistake, I think we need to manually clean up the release registry which should fix the issue. Let me know if you want to do it, otherwise I can also take a look.

Right the 14. was a mistake. But since it was a preview build -dump1 I didnt' think this would be an issue because we used to ignore preview builds on the docs and wizard.

Let me know if you want to do it, otherwise I can also take a look.

I'd really appreciate if you could help me with this 🙏 Thank you Lukas!

[Lms24]

The root cause why this entry made its way into the release registry at all is because -dump1 is not detected as a preview release version. Our craft target for the release registry doesn't create any entries for preview versions. However, in this case, the detection failed and we then updated latest.json because of the version comparison check I mentioned above.

I opened getsentry/craft#561 to fix this in craft, though I'd argue this might happen again if we don't change our approach of detecting preview releases.

Regarding cleanup: I'll open a PR to remove the preview release entries and re-sync the latest.json symlinks