Skip to content

feat: Make dsn in code blocks searchable #11393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 19, 2024
Merged

feat: Make dsn in code blocks searchable #11393

merged 3 commits into from
Sep 19, 2024

Conversation

@chargome
Copy link
Member

@chargome chargome commented Sep 19, 2024

fixes #11288

  • Adds a search field for dsn selection in code blocks.
  • Search bar will only be displayed when the user has more than 5 projects
  • Refactor codeKeywords component

light:
Screenshot 2024-09-19 at 11 48 25

dark:
Screenshot 2024-09-19 at 11 49 43

@chargome chargome requested review from Lms24 and a-hariti September 19, 2024 09:55
@chargome chargome self-assigned this Sep 19, 2024
@vercel
Copy link

vercel bot commented Sep 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 19, 2024 11:59am
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 19, 2024 11:59am
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 19, 2024 11:59am

@codecov
Copy link

codecov bot commented Sep 19, 2024 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 1.82kB (0.01%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 7.43MB 860 bytes ⬆️
sentry-docs-edge-server-array-push 257.01kB 3 bytes ⬇️
sentry-docs-client-array-push 6.4MB 968 bytes ⬆️

Lms24
Lms24 approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work, thanks a lot!

@chargome chargome mentioned this pull request Sep 19, 2024
Closed
@chargome chargome merged commit 3cbe50f into master Sep 19, 2024
8 checks passed
@chargome chargome deleted the cg/feat-dsn-searchable branch September 19, 2024 12:27
@chargome chargome mentioned this pull request Sep 19, 2024
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Oct 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Lms24 Lms24 Lms24 approved these changes

@a-hariti a-hariti Awaiting requested review from a-hariti

Assignees

@chargome chargome

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make Project Selection searchable

3 participants

@chargome @Lms24