Skip to content

Conversation

@stayallive
Copy link
Collaborator

DESCRIBE YOUR PR

Clarify the section about local development and testing and point out Spotlight as a option.

Fixes #11337

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

@vercel
Copy link

vercel bot commented Oct 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ❌ Failed (Inspect) Nov 5, 2024 9:55am
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 9:55am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Visit Preview Nov 5, 2024 9:55am

@stayallive stayallive changed the title Update note about local development and testing PHP: Update note about local development and testing Oct 9, 2024
@codecov
Copy link

codecov bot commented Oct 9, 2024

Bundle Report

Changes will increase total bundle size by 459 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 7.46MB 6 bytes (-0.0%) ⬇️
sentry-docs-edge-server-array-push 257.07kB 3 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 6.43MB 468 bytes (0.01%) ⬆️

@getsantry getsantry bot added the Stale label Nov 5, 2024
@cleptric cleptric added wip and removed Stale labels Nov 5, 2024
@getsentry getsentry deleted a comment from getsantry bot Nov 5, 2024
@getsentry getsentry deleted a comment from getsantry bot Feb 20, 2025
@sfanahata
Copy link
Contributor

@stayallive - I'm doing some cleanup of this repo. Do you still want to move forward with this PR? There are some conflicts as well as some build and deployment failures that are too old for me to check, so if you want to keep this one going, please re-commit your changes and I'll take a look next week.

@stayallive
Copy link
Collaborator Author

We are working some angles, so I'll close this for now and re-submit when needed!

@stayallive stayallive closed this Apr 5, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Apr 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Laravel note on performance overhead potentially misleading

5 participants