From 7f1bf7a7e4f81bbe50bb3c4eab1724b5c5dbefc9 Mon Sep 17 00:00:00 2001 From: Dhiogo Brustolin Date: Thu, 17 Oct 2024 10:40:38 +0200 Subject: [PATCH 1/2] Upload debug Symbols extra intrusction --- platform-includes/debug-symbols-apple/_default.mdx | 10 ++++++++++ platform-includes/source-context/apple.mdx | 10 ++++++++++ 2 files changed, 20 insertions(+) diff --git a/platform-includes/debug-symbols-apple/_default.mdx b/platform-includes/debug-symbols-apple/_default.mdx index 65d6385a1b6601..d0552d20cf5349 100644 --- a/platform-includes/debug-symbols-apple/_default.mdx +++ b/platform-includes/debug-symbols-apple/_default.mdx @@ -95,6 +95,11 @@ Another option is to use warnings, and then set `GCC_TREAT_WARNINGS_AS_ERRORS` t ```bash {tabTitle:Warn on failures - nonblocking} +#Uncomment the following lines if you installed sentry-cli via Homebrew in a Apple Silicon Mac +#if [[ "$(uname -m)" == arm64 ]]; then +# export PATH="/opt/homebrew/bin:$PATH" +#fi + if which sentry-cli >/dev/null; then export SENTRY_ORG=___ORG_SLUG___ export SENTRY_PROJECT=___PROJECT_SLUG___ @@ -109,6 +114,11 @@ fi ``` ```bash {tabTitle:Error on failures - blocking} +#Uncomment the following lines if you installed sentry-cli via Homebrew in a Apple Silicon Mac +#if [[ "$(uname -m)" == arm64 ]]; then +# export PATH="/opt/homebrew/bin:$PATH" +#fi + if which sentry-cli >/dev/null; then export SENTRY_ORG=___ORG_SLUG___ export SENTRY_PROJECT=___PROJECT_SLUG___ diff --git a/platform-includes/source-context/apple.mdx b/platform-includes/source-context/apple.mdx index c72ea5ad38a7db..97837201577c62 100644 --- a/platform-includes/source-context/apple.mdx +++ b/platform-includes/source-context/apple.mdx @@ -48,6 +48,11 @@ You can upload your sources to Sentry after every build through Xcode. To do thi ```bash {tabTitle:Warn on failures - nonblocking} +#Uncomment the following lines if you installed sentry-cli via Homebrew in a Apple Silicon Mac +#if [[ "$(uname -m)" == arm64 ]]; then +# export PATH="/opt/homebrew/bin:$PATH" +#fi + if which sentry-cli >/dev/null; then export SENTRY_ORG=___ORG_SLUG___ export SENTRY_PROJECT=___PROJECT_SLUG___ @@ -62,6 +67,11 @@ fi ``` ```bash {tabTitle:Error on failures - blocking} +#Uncomment the following lines if you installed sentry-cli via Homebrew in a Apple Silicon Mac +#if [[ "$(uname -m)" == arm64 ]]; then +# export PATH="/opt/homebrew/bin:$PATH" +#fi + if which sentry-cli >/dev/null; then export SENTRY_ORG=___ORG_SLUG___ export SENTRY_PROJECT=___PROJECT_SLUG___ From bb7f58148c1d2e0f2c7feb0a3c3f173ec0bc0320 Mon Sep 17 00:00:00 2001 From: Dhiogo Brustolin Date: Thu, 31 Oct 2024 08:44:36 +0100 Subject: [PATCH 2/2] Apply suggestions from code review --- platform-includes/debug-symbols-apple/_default.mdx | 14 ++++++-------- platform-includes/source-context/apple.mdx | 14 ++++++-------- 2 files changed, 12 insertions(+), 16 deletions(-) diff --git a/platform-includes/debug-symbols-apple/_default.mdx b/platform-includes/debug-symbols-apple/_default.mdx index d0552d20cf5349..edb33a5b63bf7c 100644 --- a/platform-includes/debug-symbols-apple/_default.mdx +++ b/platform-includes/debug-symbols-apple/_default.mdx @@ -95,10 +95,9 @@ Another option is to use warnings, and then set `GCC_TREAT_WARNINGS_AS_ERRORS` t ```bash {tabTitle:Warn on failures - nonblocking} -#Uncomment the following lines if you installed sentry-cli via Homebrew in a Apple Silicon Mac -#if [[ "$(uname -m)" == arm64 ]]; then -# export PATH="/opt/homebrew/bin:$PATH" -#fi +if [[ "$(uname -m)" == arm64 ]]; then + export PATH="/opt/homebrew/bin:$PATH" +fi if which sentry-cli >/dev/null; then export SENTRY_ORG=___ORG_SLUG___ @@ -114,10 +113,9 @@ fi ``` ```bash {tabTitle:Error on failures - blocking} -#Uncomment the following lines if you installed sentry-cli via Homebrew in a Apple Silicon Mac -#if [[ "$(uname -m)" == arm64 ]]; then -# export PATH="/opt/homebrew/bin:$PATH" -#fi +if [[ "$(uname -m)" == arm64 ]]; then + export PATH="/opt/homebrew/bin:$PATH" +fi if which sentry-cli >/dev/null; then export SENTRY_ORG=___ORG_SLUG___ diff --git a/platform-includes/source-context/apple.mdx b/platform-includes/source-context/apple.mdx index 97837201577c62..c7c1bb40ccd6f8 100644 --- a/platform-includes/source-context/apple.mdx +++ b/platform-includes/source-context/apple.mdx @@ -48,10 +48,9 @@ You can upload your sources to Sentry after every build through Xcode. To do thi ```bash {tabTitle:Warn on failures - nonblocking} -#Uncomment the following lines if you installed sentry-cli via Homebrew in a Apple Silicon Mac -#if [[ "$(uname -m)" == arm64 ]]; then -# export PATH="/opt/homebrew/bin:$PATH" -#fi +if [[ "$(uname -m)" == arm64 ]]; then + export PATH="/opt/homebrew/bin:$PATH" +fi if which sentry-cli >/dev/null; then export SENTRY_ORG=___ORG_SLUG___ @@ -67,10 +66,9 @@ fi ``` ```bash {tabTitle:Error on failures - blocking} -#Uncomment the following lines if you installed sentry-cli via Homebrew in a Apple Silicon Mac -#if [[ "$(uname -m)" == arm64 ]]; then -# export PATH="/opt/homebrew/bin:$PATH" -#fi +if [[ "$(uname -m)" == arm64 ]]; then + export PATH="/opt/homebrew/bin:$PATH" +fi if which sentry-cli >/dev/null; then export SENTRY_ORG=___ORG_SLUG___