Skip to content

Conversation

@bruno-garcia
Copy link
Member

Uploading symbols is critical, we should mention that earlier and make it more prominent

Disabling is the least relevant thing (also why would someone disable, should we say it on the docs?)

be explicit code snippet is to disable the feature
touch on symbol upload earlier on the doc
@vercel
Copy link

vercel bot commented Oct 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 19, 2024 9:29pm
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 19, 2024 9:29pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Oct 19, 2024 9:29pm

@codecov
Copy link

codecov bot commented Oct 19, 2024

Bundle Report

Changes will increase total bundle size by 192.43kB (1.35%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 7.71MB 192.44kB (2.56%) ⬆️
sentry-docs-edge-server-array-push 257.08kB 3 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 6.44MB 6 bytes (-0.0%) ⬇️

Copy link
Contributor

@bitsandfoxes bitsandfoxes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a remnant of when we had it as experimental and wanted to provide a quick and clear way to opt-out.

@bruno-garcia bruno-garcia merged commit 948481a into master Oct 21, 2024
11 checks passed
@bruno-garcia bruno-garcia deleted the bruno-garcia-patch-1 branch October 21, 2024 14:27
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants