Skip to content

Conversation

@martinhaintz
Copy link
Contributor

DESCRIBE YOUR PR

In Flutter we introduced redaction via masking for Screenshots and Session Replay, therefore I updated the docs.

There were already infos, for masking in the Session Replay which I consolidated and extended and linked to from Screenshots and Session Replay.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

EXTRA RESOURCES

@vercel
Copy link

vercel bot commented Nov 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 9:25am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Dec 9, 2024 9:25am
develop-docs ⬜️ Ignored (Inspect) Visit Preview Dec 9, 2024 9:25am

@codecov
Copy link

codecov bot commented Nov 25, 2024

Bundle Report

Changes will increase total bundle size by 204 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.13MB 210 bytes (0.0%) ⬆️
sentry-docs-client-array-push 9.02MB 6 bytes (-0.0%) ⬇️

…ierarchy

* master: (28 commits)
  feat(angular): Update SDK provider setup for Angular 19 (#11921)
  feat(dynamic-sampling): adapt docs to new dynamic sampling logic (#11886)
  update banner for post-launch week promotion (#11964)
  chore(android): Add masking options to AndroidManifest (#11863)
  Bump API schema to 2126f7dd (#11965)
  chore(Profiling): Add callouts and links to Android Profiling troubleshooting info (#11905)
  docs(flutter): Use sentry flutter init in samples (#11858)
  use native crypto to generate uuid (#11959)
  fix vercel integration 404 (#11958)
  Add RN Replay Privacy page (#11798)
  feat(dashboards): Add docs for Dashboard Edit Access Selector (#11822)
  feat(app-starts): Add RN SDK min version (#11650)
  feat(realy): Add Relay best practices guide (#11914)
  docs(sdks): New Scope APIs (#11943)
  docs(sdks): Span Sampling (#11940)
  Add include explaining sample code options (#11866)
  devenv: internal troubleshooting (#11947)
  Bump API schema to 0b18bfae (#11946)
  Bump API schema to 2bee5317 (#11945)
  feat: Link to Replay Issues when we mention Perf Issues as well (#11933)
  ...
Copy link
Collaborator

@vaind vaind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good, thanks!

@martinhaintz martinhaintz marked this pull request as ready for review December 9, 2024 09:12
@martinhaintz martinhaintz enabled auto-merge (squash) December 9, 2024 09:12
@martinhaintz martinhaintz merged commit 6e67955 into master Dec 9, 2024
11 checks passed
@martinhaintz martinhaintz deleted the martinhaintz/redact-screenshots-via-view-hierarchy branch December 9, 2024 09:25
Lms24 pushed a commit that referenced this pull request Dec 13, 2024
…ions (#11930)

* add masking options

* minor arrangement changes

* add specific intro for screenshot and session replay

* Update docs/platforms/flutter/session-replay/index.mdx

Co-authored-by: Ivan Dlugos <[email protected]>

---------

Co-authored-by: Martin Haintz <[email protected]>
Co-authored-by: Ivan Dlugos <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Dec 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants