-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
chore(apple): add SentrySDK.startProfiler to configure #13014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
Bundle ReportChanges will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-client-array-pushAssets Changed:
view changes for bundle: sentry-docs-server-cjsAssets Changed:
|
|
@armcknight it would be great if you could add some insights if these changes makes sense |
philipphofmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this change makes sense. @armcknight what do you think?
| func applicationDidBecomeActive(_ application: UIApplication) { | ||
| SentrySDK.startProfiler() | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this doesn't add too much noise. We already mention SentrySDK.startProfiler() above and tell the user that they have to manually start and stop the profiler.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that this is duplicate text. I am questioning the value of displaying the SentrySDK.startProfile() in the didFinishLaunch method alltogether.
|
I actually just noticed that the Apple Documentation states the following:
AFAIK scenes are the default for creating new Xcode projects, so maybe we should also mention |
kahest
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@philprime this is probably superseded by #13197 - in general I think we're moving away from showing start/stopProfiler on this page completely
|
Closing in favor of #13197 |
DESCRIBE YOUR PR
The current configuration docs display an example usage of the
SentrySDK.startProfiler()andSentrySDK.stopProfiler()and mentions that the call of stop is optional, as the profiler will automatically stop when going to the background.Now if a user calls
SentrySDK.startProfiler()in thedidFinishLaunchinghook, which is only called once per app start, the profiler would stop when the app goes to the first going to the background and not start again.I would like to propose/discuss if the
SentrySDK.startProfiler()should be used inapplicationDidBecomeActive(_:)too.IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
cc @jas-kas