Skip to content

Conversation

@ryan953
Copy link
Member

@ryan953 ryan953 commented Apr 4, 2025

The change is on this page, for all the frameworks i found that have a specific Browser Integrations section
https://docs.sentry.io/platforms/javascript/configuration/integrations/

I've grouped all the FF integrations together. This is an improvement as-is because we're giving more reach to the FF integrations for JS frameworks with a browser component.

Pages will look like this now:

SCR-20250404-ndiv

@vercel
Copy link

vercel bot commented Apr 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2025 11:13pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Apr 4, 2025 11:13pm
develop-docs ⬜️ Ignored (Inspect) Visit Preview Apr 4, 2025 11:13pm

@ryan953 ryan953 requested review from a team April 4, 2025 21:45
@aliu39
Copy link
Member

aliu39 commented Apr 4, 2025

Personally I like keeping them alphabetical, if theres no dedicated section to nest flags.

I think how it's structured now is auto enabled on top, otherwise alphabetical

@codecov
Copy link

codecov bot commented Apr 4, 2025

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 11.13MB -9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.47MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 868.7kB -0.0%
static/chunks/8165-*.js -3 bytes 410.1kB -0.0%
server/middleware-*.js -5.55kB 1.0kB -84.74%
server/middleware-*.js 5.55kB 6.55kB 555.3% ⚠️
static/pTZugAV94iOrc8rK0sRKN/_buildManifest.js (New) 578 bytes 578 bytes 100.0% 🚀
static/pTZugAV94iOrc8rK0sRKN/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/5VjVU8szhtAqL5oYrnjhh/_buildManifest.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/5VjVU8szhtAqL5oYrnjhh/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.75MB -0.0%
../instrumentation.js -3 bytes 1.08MB -0.0%
9523.js -3 bytes 1.05MB -0.0%

@ryan953
Copy link
Member Author

ryan953 commented Apr 4, 2025

Personally I like keeping them alphabetical, if theres no dedicated section to nest flags.

I think how it's structured now is auto enabled on top, otherwise alphabetical

oh, i did notice that the whole thing wasn't sorted but not that it's in two parts. i can sort it to be auto-enabled vs. the-rest.

@ryan953 ryan953 merged commit b42fc6b into master Apr 4, 2025
11 checks passed
@ryan953 ryan953 deleted the ryan953/flags-integrations-table branch April 4, 2025 23:22
@github-actions github-actions bot locked and limited conversation to collaborators Apr 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants