-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
docs(js): Create Nuxt Quick Start guide for wizard installation #13286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
| problem. | ||
|
|
||
| </Expandable> | ||
| <PlatformContent includePath="getting-started-features-expandable" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created a new platform-include for this content and updated existing quick start guides to use it
| 2. Click the "Throw Sample Error" button, which triggers an error and starts a performance trace on the client side. | ||
|
|
||
| ## Verify | ||
| To test the server side as well, refer to the "Verify" section in the [Manual setup guide](/platforms/javascript/guides/nuxt/manual-setup/). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For a potential future update:
Could we update the wizard to create an example that lets users test client and server side?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@s1gr1d can you help answer ⬆ this question?
I was wondering why the wizard only creates the component and not a route like the Next.js wizard?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the example page that is created in the Nuxt wizard, there is also a call to an API route which is created by the wizard as well. But all of this is only created when the wizard detects the app.vue file. Without this, we cannot be sure whether the user is using the Nuxt routing mechanism. With only one page, the Nuxt project would not be using the Nuxt router and the wizard should not change the routing mechanism.
But I think it should be fine to create the component and the API route 🤔 So the component could call the API
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @s1gr1d!
I created an issue in the wizard repo getsentry/sentry-wizard#940
I'll leave this as is for now 👍
| throw new Error("Sentry Example API Route Error"); | ||
| }); | ||
| ``` | ||
| 1. Open the example page `/sentry-example-page` in your browser. For most Nuxt applications, this will be at localhost. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we write the full path here? Since it's always on localhost 🤔
| 1. Open the example page `/sentry-example-page` in your browser. For most Nuxt applications, this will be at localhost. | |
| 1. Open the example page `/sentry-example-page` in your browser. For most Nuxt applications, this will be at localhost:3000/sentry-example-page. |
Co-authored-by: Sigrid Huemer <[email protected]>
Bundle ReportChanges will increase total bundle size by 999 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
* create Nuxt Quick Start guide for wizard setup; create and use new platform-includes * Apply suggestions from code review Co-authored-by: Sigrid Huemer <[email protected]> --------- Co-authored-by: Sigrid Huemer <[email protected]>
DESCRIBE YOUR PR
Closes:
#13188#13187IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
EXTRA RESOURCES