Skip to content

Conversation

@coolguyzone
Copy link
Contributor

DESCRIBE YOUR PR

Tell us what you're changing and why. If your PR resolves an issue, please link it so it closes automatically.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

@vercel
Copy link

vercel bot commented Oct 31, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
sentry-docs Ready Ready Preview Comment Oct 31, 2025 10:14pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
develop-docs Ignored Ignored Oct 31, 2025 10:14pm

Comment on lines +208 to +218
/>
- <LinkWithPlatformIcon
platform="python.aws-lambda"
label="AWS Lambda"
url="/platforms/python/guides/aws-lambda/metrics/"
/>
- <LinkWithPlatformIcon
platform="python.gcp-functions"
label="Google Cloud Functions"
url="/platforms/python/guides/gcp-functions/metrics/"
/>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: New documentation links are silently redirected to old span-metrics content due to existing redirects.js rules.
Severity: HIGH | Confidence: 0.90

🔍 Detailed Analysis

New documentation links added in docs/product/explore/metrics/getting-started/index.mdx (lines 19-218), such as /platforms/javascript/metrics/ and /platforms/python/guides/django/metrics/, will be intercepted by existing redirect rules in redirects.js. These rules, like { source: '/platforms/javascript/metrics/:path*', destination: '/platforms/javascript/tracing/span-metrics/:path*', }, will silently redirect users to older span-metrics documentation instead of the intended new Metrics product documentation. This occurs when users click on these newly introduced links.

💡 Suggested Fix

Remove or update the conflicting platform-specific metrics redirects in redirects.js, or confirm that the new documentation paths do not collide with existing redirect patterns.

🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: docs/product/explore/metrics/getting-started/index.mdx#L19-L218

Potential issue: New documentation links added in
`docs/product/explore/metrics/getting-started/index.mdx` (lines 19-218), such as
`/platforms/javascript/metrics/` and `/platforms/python/guides/django/metrics/`, will be
intercepted by existing redirect rules in `redirects.js`. These rules, like `{ source:
'/platforms/javascript/metrics/:path*', destination:
'/platforms/javascript/tracing/span-metrics/:path*', }`, will silently redirect users to
older span-metrics documentation instead of the intended new Metrics product
documentation. This occurs when users click on these newly introduced links.

Did we get this right? 👍 / 👎 to inform future reviews.

@coolguyzone coolguyzone marked this pull request as draft October 31, 2025 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants