-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
ref(develop/spans): Replace is_remote with is_segment in Span Protocol
#15415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Dav1dde
approved these changes
Nov 5, 2025
| | `name` | string | Yes | A low cardinality description of what the span represents (e.g., "GET /users", "database.query") | | ||
| | `status` | string | Yes | Status of the span operation. Either `"ok"` or `"error"` | | ||
| | `is_remote` | boolean | Yes | Whether the SpanContext creating the span was received from somewhere else or locally generated | | ||
| | `is_segment` | boolean | Yes | Whether the span is a segment span | |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically we decided not to require it for compatibility reasons with otel, but I am good with keeping it as required here for our own SDKs 👍.
codyde
added a commit
that referenced
this pull request
Nov 9, 2025
…ntry/sentry-docs into docs/span-metrics-examples * 'docs/span-metrics-examples' of https://github.com/getsentry/sentry-docs: (27 commits) Adding logs callout in relevant breadcrumbs docs. (#15432) docs(self-hosted): Troubleshooting guide to invalidate projectconfigs (#15377) docs(js): Add metrics page (#15353) fix encoding for minification (#15429) update instructions for string minification (#15421) getsentry/relay@938582a fix: typos in TanStack Start docs (#15425) feat: Add firebase docs integration (#15310) feat(develop-docs): add index and subpages for Telemetry Buffer (#15424) docs(integration): Update Linear Agent Docs (#15420) feat(cloudflare): Fixed snippet to be cloudflare specific (#15369) chore(aws-lambda): Add troubleshooting section with known issue (#15414) getsentry/relay@5e23f1a docs(size-analysis): Align code boxes and remove vcsInfo links (#15418) feat(develop-docs): Add telemetry buffer page (#15411) Add Composer requirement to PHP platform guide (#15319) Updated link for version compatability (#15311) (WIP) Mtopo27/size analysis docs (#15256) Metrics Product Docs (#15375) ref(develop/spans): Replace `is_remote` with `is_segment` in Span Protocol (#15415) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We decided to remove the
is_remotefield on the Span v2 items in favour of the newis_segmentfield.