feat(telemetry-buffer): Add envelope size limits #15875
Conversation
Also update the envelpe size limits according to current Relay config.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@loewenheim, could you maybe double-check the Relay size limits? |
|
As @loewenheim is on PTO, @Dav1dde, could you maybe have a look at this PR? |
|
@loewenheim could you maybe double check the size limits in this PR, please? |
| Event ingestion imposes limits on the size and number of Items in Envelopes. | ||
| These limits are subject to future change and defined currently as (see [Relay config source](https://github.com/getsentry/relay/blob/master/relay-config/src/config.rs)): | ||
|
|
||
| - *40 MiB* for a compressed envelope request |
There was a problem hiding this comment.
This no longer exists, everything should be 200MiB now, but we do validate the uncompressed size to be within the 200MiB limit.
|
|
||
| - *40 MiB* for a compressed envelope request | ||
| - *200 MiB* for a full envelope after decompression | ||
| - *200 MiB* for all attachments combined |
There was a problem hiding this comment.
Technically redundant with the envelope size, but maybe good to clarify for the unreal endpoint
| - *40 MiB* for a compressed envelope request | ||
| - *200 MiB* for a full envelope after decompression | ||
| - *200 MiB* for all attachments combined | ||
| - *200 MiB* for each attachment item |
There was a problem hiding this comment.
These limits depend on the item type. E.g. events (errors/transactions) have different limits, there is no limit just generally says an item can't be bigger than X, it's just that these items are also part of the envelope.
| - *200 MiB* for all attachments combined | ||
| - *200 MiB* for each attachment item | ||
| - *1 MiB* for event (errors and transactions), span, log, and metric (statsd, buckets, meta) envelope items. | ||
| - *2 KiB* average per metric within an envelope. Relay discards the entire envelope if the average of all metrics within it exceeds 2 KiB. |
There was a problem hiding this comment.
The average is an implementation detail, it's 2KiB and these limits will be consistently enforced somewhere else (non average).
Also update the envelope size limits according to the current Relay config.