integration test: MSBuild 16 & NET 5.0

Author: jpnurmi

.github/workflows/build.yml

@@ -271,7 +271,7 @@ jobs:
         with:
           path: integration-test
 
-  msbuild:
+  msbuild-sentry:
     needs: build-sentry-native
     name: MSBuild
     runs-on: windows-latest
@@ -313,6 +313,64 @@ jobs:
             msbuild.binlog
           if-no-files-found: ignore
 
+      - name: Archive NuGet Packages
+        uses: actions/upload-artifact@v4
+        with:
+          name: msbuild-${{ github.sha }}
+          if-no-files-found: error
+          path: |
+            src/**/Release/*.nupkg
+            src/**/Release/*.snupkg
+
+  msbuild-test:
+    needs: msbuild-sentry
+    name: MSBuild Test (${{ matrix.name }})
+    runs-on: windows-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        include:
+          - name: VS 2022
+          - name: VS 2019
+            vs-build-tools: 2019
+            vs-version: '[16.0,17.0)'
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v5
+        with:
+          submodules: recursive
+
+      - name: Install .NET 5.0 SDK
+        uses: actions/setup-dotnet@v4
+        with:
+          dotnet-version: '5.0.x'
+
+      - name: Install .NET SDK
+        uses: actions/setup-dotnet@v4
+        with:
+          global-json-file: global.json
+
+      - name: Install VS Build Tools
+        if: ${{ matrix.vs-build-tools }}
+        run: choco install visualstudio${{ matrix.vs-build-tools }}buildtools
+
+      - name: Setup MSBuild
+        uses: microsoft/setup-msbuild@6fb02220983dee41ce7ae257b6f4d8f9bf5ed4ce # v2
+        with:
+          vs-version: ${{ matrix.vs-version }}
+
+      - name: Fetch NuGet Packages
+        uses: actions/download-artifact@v5
+        with:
+          name: msbuild-${{ github.sha }}
+          path: src
+
+      - name: Run MSBuild tests
+        uses: getsentry/github-workflows/sentry-cli/integration-test/@a5e409bd5bad4c295201cdcfe862b17c50b29ab7 # v2.14.1
+        with:
+          path: integration-test/msbuild.Tests.ps1
+
   # Unsupported Native AOT runtimes should have SentryNative auto-disabled
   # to avoid native library loading errors on startup.
   unsupported-aot:

integration-test/common.ps1

@@ -197,7 +197,7 @@ BeforeAll {
         if ($type -eq 'console')
         {
             AddPackageReference $name 'Sentry'
-            if (!$IsMacOS -or $framework -eq 'net8.0')
+            if ((!$IsMacOS -or $framework -eq 'net8.0') -and $framework -ne 'net5.0')
             {
                 @"
 <Project>

integration-test/msbuild.Tests.ps1

@@ -0,0 +1,66 @@
+# This file contains test cases for https://pester.dev/
+Set-StrictMode -Version Latest
+$ErrorActionPreference = 'Stop'
+. $PSScriptRoot/common.ps1
+
+$HasMSBuild = (Get-Command msbuild -ErrorAction SilentlyContinue)
+
+Describe 'MSBuild app (<framework>)' -ForEach @(
+    @{ framework = 'net5.0' },
+    @{ framework = 'net8.0' },
+    @{ framework = 'net9.0' }
+) -Skip:(-not $IsWindows -or -not $HasMSBuild) {
+    BeforeAll {
+        $path = './msbuild-app'
+        DotnetNew 'console' $path $framework
+        @'
+using Sentry;
+
+SentrySdk.Init(options =>
+{
+    options.Dsn = args[0];
+    options.Debug = true;
+});
+
+SentrySdk.CaptureMessage("Hello from MSBuild app");
+'@ | Out-File $path/Program.cs
+
+        function Test-NetSdkInstalled([string]$framework) {
+            $version = $framework -replace 'net(\d+)\.0', '$1'
+            $sdks = dotnet --list-sdks
+            return $null -ne ($sdks | Where-Object { $_ -match "^$version\." })
+        }
+
+        Push-Location $path
+    }
+
+    BeforeEach {
+        Remove-Item "./bin/Release/$framework" -Recurse -ErrorAction SilentlyContinue
+        Remove-Item "./obj/Release/$framework" -Recurse -ErrorAction SilentlyContinue
+    }
+
+    AfterAll {
+        Pop-Location
+    }
+
+    It 'builds without warnings and is able to capture a message' {
+        if (-not (Test-NetSdkInstalled $framework)) {
+            Set-ItResult -Skipped -Because "$framework is not installed"
+        }
+
+        $result = Invoke-SentryServer {
+            Param([string]$url)
+            $dsn = $url.Replace('http://', 'http://key@') + '/0'
+
+            msbuild msbuild-app.csproj -t:Restore,Build -p:Configuration=Release -p:TreatWarningsAsErrors=true
+            | ForEach-Object { Write-Host $_ }
+            $LASTEXITCODE | Should -Be 0
+
+            msbuild msbuild-app.csproj -t:Run -p:Configuration=Release -p:RunArguments=$dsn
+            | ForEach-Object { Write-Host $_ }
+            $LASTEXITCODE | Should -Be 0
+        }
+        $result.HasErrors() | Should -BeFalse
+        $result.Envelopes() | Should -AnyElementMatch "`"message`":`"Hello from MSBuild app`""
+    }
+}