Update X-Sentry-Auth header to include correct sdk name and version (#1333)

* Update X-Sentry-Auth header to include correct SDK name and version

Co-authored-by: Josh DeGraw <[email protected]>
Co-authored-by: Bruno Garcia <[email protected]>

Author: 3 people

CHANGELOG.md

@@ -6,6 +6,10 @@
 
 - Move to stable v6 for `Microsoft.Extensions.*` packages ([#1347](https://github.com/getsentry/sentry-dotnet/pull/1347))
 
+### Fixes
+
+- Update X-Sentry-Auth header to include correct sdk name and version ([#1333](https://github.com/getsentry/sentry-dotnet/pull/1333))
+
 ## 3.12.0
 
 ### Features

src/Sentry/Internal/Http/HttpTransport.cs

@@ -267,10 +267,9 @@ internal HttpRequestMessage CreateRequest(Envelope envelope)
             }
 
             var dsn = Dsn.Parse(_options.Dsn);
-
             var authHeader =
                 $"Sentry sentry_version={_options.SentryVersion}," +
-                $"sentry_client={_options.ClientVersion}," +
+                $"sentry_client={SdkVersion.Instance.Name}/{SdkVersion.Instance.Version}," +
                 $"sentry_key={dsn.PublicKey}," +
                 (dsn.SecretKey is { } secretKey ? $"sentry_secret={secretKey}," : null) +
                 $"sentry_timestamp={_clock.GetUtcNow().ToUnixTimeSeconds()}";

test/Sentry.DiagnosticSource.Tests/ApiApprovalTests.Run.DotNet3_1.verified.txt

@@ -379,7 +379,6 @@ namespace Sentry
         public void WriteTo(System.Text.Json.Utf8JsonWriter writer) { }
         public static Sentry.SentryEvent FromJson(System.Text.Json.JsonElement json) { }
     }
-    public static class SentryEventExtensions { }
     public class SentryHttpMessageHandler : System.Net.Http.DelegatingHandler
     {
         public SentryHttpMessageHandler() { }

test/Sentry.Tests/ApiApprovalTests.Run.DotNet3_1.verified.txt

@@ -379,7 +379,6 @@ namespace Sentry
         public void WriteTo(System.Text.Json.Utf8JsonWriter writer) { }
         public static Sentry.SentryEvent FromJson(System.Text.Json.JsonElement json) { }
     }
-    public static class SentryEventExtensions { }
     public class SentryHttpMessageHandler : System.Net.Http.DelegatingHandler
     {
         public SentryHttpMessageHandler() { }

test/Sentry.Tests/Internals/Http/HttpTransportTests.cs

@@ -1,5 +1,6 @@
 using System.Net;
 using System.Net.Http;
+using System.Text.RegularExpressions;
 using Sentry.Internal.Http;
 using Sentry.Testing;
 using Sentry.Tests.Helpers;
@@ -479,6 +480,25 @@ public void CreateRequest_AuthHeader_IsSet()
         authHeader.Should().NotBeNullOrWhiteSpace();
     }
 
+    [Fact]
+    public void CreateRequest_AuthHeader_IncludesVersion()
+    {
+        // Arrange
+        var httpTransport = new HttpTransport(
+            new SentryOptions { Dsn = DsnSamples.ValidDsnWithSecret },
+            new HttpClient());
+
+        var envelope = Envelope.FromEvent(new SentryEvent());
+
+        // Act
+        using var request = httpTransport.CreateRequest(envelope);
+        var authHeader = request.Headers.GetValues("X-Sentry-Auth").FirstOrDefault();
+
+        // Assert
+        var versionString = Regex.Match(authHeader, @"sentry_client=(\S+),sentry_key").Groups[1].Value;
+        Assert.Contains(versionString, $"{SdkVersion.Instance.Name}/{SdkVersion.Instance.Version}");
+    }
+
     [Fact]
     public void CreateRequest_RequestMethod_Post()
     {