assert guids not empty (#1244)

SimonCropp · lucas-zimerman · web-flow · commit 4d36f002d7ab · 2021-10-26T16:08:54.000Z
Co-authored-by: LucasZF &lt;lucas-zimerman1@hotmail.com&gt;
diff --git a/src/Sentry.DiagnosticSource/Internals/DiagnosticSource/SentrySqlListener.cs b/src/Sentry.DiagnosticSource/Internals/DiagnosticSource/SentrySqlListener.cs
@@ -1,5 +1,6 @@
 using System;
 using System.Collections.Generic;
+using System.Diagnostics;
 using System.Linq;
 using Sentry.Extensibility;
 using Sentry.Internal.Extensions;
@@ -51,11 +52,15 @@ public SentrySqlListener(IHub hub, SentryOptions options)
 
         private void SetConnectionId(ISpan span, Guid? connectionId)
         {
+            Debug.Assert(connectionId != Guid.Empty);
+
             span.SetExtra(ConnectionExtraKey, connectionId);
         }
 
         private void SetOperationId(ISpan span, Guid? operationId)
         {
+            Debug.Assert(operationId != Guid.Empty);
+
             span.SetExtra(OperationExtraKey, operationId);
         }
 

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,6 @@`
`1`	`1`	`using System;`
`2`	`2`	`using System.Collections.Generic;`
	`3`	`+using System.Diagnostics;`
`3`	`4`	`using System.Linq;`
`4`	`5`	`using Sentry.Extensibility;`
`5`	`6`	`using Sentry.Internal.Extensions;`
`@@ -51,11 +52,15 @@ public SentrySqlListener(IHub hub, SentryOptions options)`
`51`	`52`
`52`	`53`	`private void SetConnectionId(ISpan span, Guid? connectionId)`
`53`	`54`	`{`
	`55`	`+ Debug.Assert(connectionId != Guid.Empty);`
	`56`	`+`
`54`	`57`	`span.SetExtra(ConnectionExtraKey, connectionId);`
`55`	`58`	`}`
`56`	`59`
`57`	`60`	`private void SetOperationId(ISpan span, Guid? operationId)`
`58`	`61`	`{`
	`62`	`+ Debug.Assert(operationId != Guid.Empty);`
	`63`	`+`
`59`	`64`	`span.SetExtra(OperationExtraKey, operationId);`
`60`	`65`	`}`
`61`	`66`